Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2074)

Issue 23444027: TEST COMPLETE does not appear at the end of spellchecking tests (Closed)

Created:
7 years, 3 months ago by grzegorz
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

TEST COMPLETE does not appear at the end of spellchecking tests Fix this by setting 'jsTestIsAsync = true' and calling finishJSTest() when the asynchronous spellchecking tests end. WebKit changeset: http://trac.webkit.org/changeset/154869 In addition, this CL adjusts the newly created Blink's spelling tests to dump the messages in right order. This change showed a bug in spellcheck-disable-enable.html that starts failing after turning on asynchronous spell checker, added it to TestExpectations (see crbug.com/282426 for more details). Some spellchecking tests do not verify anything asynchronously. Call the body of 'test()' directly instead of calling 'test()' in onload event. It ensures that the js-test-post.js is invoked at the end and the messages order is correct. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -91 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/editing/spelling/grammar-paste.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/grammar-paste-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/markers-input-type-text.html View 2 chunks +21 lines, -23 lines 0 comments Download
M LayoutTests/editing/spelling/markers-input-type-text-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/script-tests/spellcheck-paste.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-async.html View 2 chunks +4 lines, -5 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-async-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-disable-enable.html View 3 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/editing/spelling/spellcheck-disable-enable-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-editable-on-focus.html View 3 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-editable-on-focus-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-editable-on-focus-sync.html View 2 chunks +18 lines, -22 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-editable-on-focus-sync-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-input-search-crash.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/editing/spelling/spellcheck-input-search-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/spellcheck-paste-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-queue.html View 2 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-queue-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-huge-text.html View 2 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-huge-text-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
grzegorz
7 years, 3 months ago (2013-08-30 15:18:03 UTC) #1
gmorrita
lgtm.
7 years, 3 months ago (2013-09-02 03:46:41 UTC) #2
Hajime Morrita
from correct address :-/
7 years, 3 months ago (2013-09-02 03:48:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/23444027/1
7 years, 3 months ago (2013-09-02 03:48:20 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 05:25:11 UTC) #5
Message was sent while issue was closed.
Change committed as 157059

Powered by Google App Engine
This is Rietveld 408576698