Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: Source/bindings/v8/V8GCController.cpp

Issue 23444025: Remove calls to to-be-deprecated Persistent functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptWrappable.h ('k') | Source/bindings/v8/V8ValueCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8GCController.cpp
diff --git a/Source/bindings/v8/V8GCController.cpp b/Source/bindings/v8/V8GCController.cpp
index 92976b8efcbe0ca680608df35128a7df28cf3b17..98c755bbfc4fa7d17b8034919fdeb2bee2dad39d 100644
--- a/Source/bindings/v8/V8GCController.cpp
+++ b/Source/bindings/v8/V8GCController.cpp
@@ -209,7 +209,7 @@ private:
// v8::Persistent.
UnsafePersistent<v8::Object> unsafeWrapper = (*nodeIterator)->unsafePersistent();
v8::Persistent<v8::Object>* wrapper = unsafeWrapper.persistent();
- wrapper->MarkPartiallyDependent(isolate);
+ wrapper->MarkPartiallyDependent();
// FIXME: update this to use the upcasting function which v8 will provide
v8::Persistent<v8::Value>* value = reinterpret_cast<v8::Persistent<v8::Value>*>(wrapper);
isolate->SetObjectGroupId(*value, id);
@@ -242,7 +242,7 @@ public:
ASSERT(V8DOMWrapper::maybeDOMWrapper(*wrapper));
- if (value->IsIndependent(m_isolate))
+ if (value->IsIndependent())
return;
WrapperTypeInfo* type = toWrapperTypeInfo(*wrapper);
@@ -272,7 +272,7 @@ public:
if (classId == v8DOMNodeClassId) {
UNUSED_PARAM(m_isolate);
ASSERT(V8Node::HasInstanceInAnyWorld(*wrapper, m_isolate));
- ASSERT(!value->IsIndependent(m_isolate));
+ ASSERT(!value->IsIndependent());
Node* node = static_cast<Node*>(object);
@@ -283,7 +283,7 @@ public:
if (m_constructRetainedObjectInfos)
m_groupsWhichNeedRetainerInfo.append(root);
} else if (classId == v8DOMObjectClassId) {
- ASSERT(!value->IsIndependent(m_isolate));
+ ASSERT(!value->IsIndependent());
void* root = type->opaqueRootForGC(object, m_isolate);
m_isolate->SetObjectGroupId(*value, v8::UniqueId(reinterpret_cast<intptr_t>(root)));
} else {
« no previous file with comments | « Source/bindings/v8/ScriptWrappable.h ('k') | Source/bindings/v8/V8ValueCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698