Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "chromeos/printing/fake_printer_detector.h" | |
| 6 | |
| 7 #include <algorithm> | |
| 8 #include <iterator> | |
| 9 #include <memory> | |
| 10 | |
| 11 #include "base/bind.h" | |
| 12 #include "base/memory/ptr_util.h" | |
| 13 #include "base/strings/stringprintf.h" | |
| 14 #include "base/threading/sequenced_task_runner_handle.h" | |
| 15 #include "base/time/time.h" | |
| 16 #include "chromeos/printing/printer_detector.h" | |
| 17 | |
| 18 namespace chromeos { | |
| 19 | |
| 20 // static | |
| 21 std::unique_ptr<PrinterDetector> PrinterDetector::Create() { | |
| 22 return base::MakeUnique<FakePrinterDetector>(); | |
| 23 } | |
| 24 | |
| 25 FakePrinterDetector::~FakePrinterDetector() {} | |
| 26 | |
| 27 bool FakePrinterDetector::StartDiscovery() { | |
| 28 discovery_running_ = true; | |
| 29 base::SequencedTaskRunnerHandle::Get()->PostNonNestableDelayedTask( | |
| 30 FROM_HERE, base::Bind(&FakePrinterDetector::EmitPrinters, | |
| 31 weak_ptr_factory_.GetWeakPtr(), 0, 2), | |
| 32 base::TimeDelta::FromMilliseconds(2000)); | |
| 33 return true; | |
| 34 } | |
| 35 | |
| 36 bool FakePrinterDetector::StopDiscovery() { | |
| 37 discovery_running_ = false; | |
| 38 return true; | |
| 39 } | |
| 40 | |
| 41 void FakePrinterDetector::SetObserver(PrinterDetector::Observer* observer) { | |
| 42 observer_ = observer; | |
| 43 } | |
| 44 | |
| 45 FakePrinterDetector::FakePrinterDetector() | |
| 46 : discovery_running_(false), observer_(nullptr), weak_ptr_factory_(this) { | |
| 47 for (int i = 0; i < 12; i++) { | |
| 48 // printer doesn't have a ppd | |
| 49 printers_.emplace_back(base::StringPrintf("GUID%2d", i)); | |
| 50 printers_[i].set_display_name(base::StringPrintf("PrinterName%2d", i)); | |
| 51 printers_[i].set_description( | |
| 52 base::StringPrintf("Printer%2dDescription", i)); | |
| 53 printers_[i].set_manufacturer("Chromium"); | |
| 54 printers_[i].set_model(i % 3 == 0 ? "Inkjet" : "Laser Maker"); | |
| 55 printers_[i].set_uri( | |
| 56 base::StringPrintf("lpr://192.168.1.%d:9100/bldg/printer", i)); | |
| 57 printers_[i].set_uuid( | |
| 58 base::StringPrintf("UUID-%4d-%4d-%4d-UUID", i * 3, i * 2, i)); | |
| 59 } | |
| 60 } | |
| 61 | |
| 62 void FakePrinterDetector::EmitPrinters(size_t start, size_t end) { | |
| 63 if (!discovery_running_) | |
| 64 return; | |
| 65 | |
| 66 size_t clipped_end = std::min(printers_.size(), end); | |
| 67 if (observer_) { | |
| 68 auto start_iter = printers_.begin(); | |
| 69 std::advance(start_iter, start); | |
| 70 auto end_iter = printers_.begin(); | |
| 71 std::advance(end_iter, end); | |
| 72 std::vector<Printer> subset(start_iter, end_iter); | |
| 73 observer_->OnPrintersFound(subset); | |
| 74 } | |
| 75 | |
| 76 if (clipped_end < end) { | |
|
xdai1
2016/09/19 18:56:10
should be if (clipped_end < printers_.size()) ?
skau
2016/09/20 01:56:47
I've changed it to end < printers_.size() since th
xdai1
2016/09/20 04:16:50
I think It is incorrect to use end here since |end
skau
2016/10/03 22:57:26
Done.
| |
| 77 base::SequencedTaskRunnerHandle::Get()->PostNonNestableDelayedTask( | |
| 78 FROM_HERE, base::Bind(&FakePrinterDetector::EmitPrinters, | |
| 79 weak_ptr_factory_.GetWeakPtr(), end, end + end), | |
|
xdai1
2016/09/19 18:56:10
I guess the last two parameters should be (clipped
skau
2016/09/20 01:56:47
Depends if you'd rather get [0,1],[2,3],...[10,11]
| |
| 80 base::TimeDelta::FromMilliseconds(2000)); | |
| 81 } | |
| 82 } | |
| 83 | |
| 84 } // namespace chromeos | |
| OLD | NEW |