DevTools: Build release mode using JS and Python

DevTools: Build release mode using JS and Python

Enables users to build release mode with only a frontend checkout
and without using GN or Ninja.

Instructions:
- Go to devtools/scripts/js_build
- Run "npm install"
- Run "npm run build"
- Release mode generated in devtools/release

BUG=642046
Committed: https://crrev.com/0becd9796f403d230751840a5c21b9a3e81d3bcf
Cr-Commit-Position: refs/heads/master@{#419660}

[chenwilliam, 2016-09-17 00:25:01]

Patchset #2 (id:20001) has been deleted

[chenwilliam, 2016-09-17 00:27:15]

Patchset #2 (id:40001) has been deleted

[chenwilliam, 2016-09-17 00:49:41]

Description was changed from

==========
DevTools: Build release mode using JS and Python

BUG=642046
==========

to

==========
DevTools: Build release mode using JS and Python

Enables users to build release mode with only a frontend checkout
and without using GN or Ninja.

Instructions:
- Go to devtools/scripts/js_build
- Run "npm install"
- Run "npm run build"
- Release mode generated in devtools/release

BUG=642046
==========

[chenwilliam, 2016-09-17 00:49:41]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[chenwilliam, 2016-09-17 00:58:41]

PTAL. Originally I aimed to replace our Python scripts with JS scripts, but I
think this approach  where gulp wraps around our Python scripts is better for
the interim period where we are maintaining both the existing build system and
developing this new build system. 

This should enable us to do builds on Travis CI w/ only the github checkout and
frees us from having to use Chromium-specific build tools (GN, ninja).

I included the simple test script and the diff output from our existing and new
build systems that helped me sanity check this work.

[pfeldman, 2016-09-19 22:55:34]

lgtm

https://codereview.chromium.org/2344353004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/scripts/js_build/gulpfile.js (right):

https://codereview.chromium.org/2344353004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/js_build/gulpfile.js:80: var
browserProtocolURL =
"https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/core/inspector/browser_protocol.json?format=TEXT";
Seems wrong to fetch every time I build.

[chenwilliam, 2016-09-20 00:39:04]

https://codereview.chromium.org/2344353004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/scripts/js_build/gulpfile.js (right):

https://codereview.chromium.org/2344353004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/js_build/gulpfile.js:80: var
browserProtocolURL =
"https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/core/inspector/browser_protocol.json?format=TEXT";
On 2016/09/19 22:55:33, pfeldman wrote:
> Seems wrong to fetch every time I build.

Agreed. For the hosted mode server, we cache the commit hash of the browser on
the remote debugging port. In this case, we could get the Chromium commit hash
of the current GitHub checkout by inspecting the commit message since the
buildbot adds the Chromium commit hash and then use the cache when your checkout
hasn't changed.

[chenwilliam, 2016-09-20 00:39:11]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-09-20 00:40:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:49:23]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-09-20 02:52:07]

Description was changed from

==========
DevTools: Build release mode using JS and Python

Enables users to build release mode with only a frontend checkout
and without using GN or Ninja.

Instructions:
- Go to devtools/scripts/js_build
- Run "npm install"
- Run "npm run build"
- Release mode generated in devtools/release

BUG=642046
==========

to

==========
DevTools: Build release mode using JS and Python

Enables users to build release mode with only a frontend checkout
and without using GN or Ninja.

Instructions:
- Go to devtools/scripts/js_build
- Run "npm install"
- Run "npm run build"
- Release mode generated in devtools/release

BUG=642046

Committed: https://crrev.com/0becd9796f403d230751840a5c21b9a3e81d3bcf
Cr-Commit-Position: refs/heads/master@{#419660}
==========

[commit-bot: I haz the power, 2016-09-20 02:52:08]

Patchset 2 (id:??) landed as
https://crrev.com/0becd9796f403d230751840a5c21b9a3e81d3bcf
Cr-Commit-Position: refs/heads/master@{#419660}

[vinodsonkusare77_gmail.com, 2016-09-20 08:19:07]

https://youtu.be/s2mEASqcipA?list=UUWQUZfAdokV83KKjLl-sDeQ

On Tue, Sep 20, 2016 at 8:22 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 2 (id:??) landed as
> https://crrev.com/0becd9796f403d230751840a5c21b9a3e81d3bcf
> Cr-Commit-Position: refs/heads/master@{#419660}
>
> https://codereview.chromium.org/2344353004/
>
> --
> You received this message because you are subscribed to the Google Groups
> "DevTools Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to devtools-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[vinodsonkusare77_gmail.com, 2016-09-20 08:19:08]

https://youtu.be/s2mEASqcipA?list=UUWQUZfAdokV83KKjLl-sDeQ

On Tue, Sep 20, 2016 at 8:22 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 2 (id:??) landed as
> https://crrev.com/0becd9796f403d230751840a5c21b9a3e81d3bcf
> Cr-Commit-Position: refs/heads/master@{#419660}
>
> https://codereview.chromium.org/2344353004/
>
> --
> You received this message because you are subscribed to the Google Groups
> "DevTools Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to devtools-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.