Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2344353002: Test setting Analyser.fftSize resets state (Closed)

Created:
4 years, 3 months ago by Raymond Toy
Modified:
4 years, 2 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test setting Analyser.fftSize resets state When the fftSize of an AnalyserNode is changed, the internal state used for managing the smoothing of the FFT data should be reset. Add test for this. BUG=647708 TEST=realtimeanalyser-fftsize-reset.html Committed: https://crrev.com/647f68a193fdf3a1eeb26fd51badf0bffeb18edc Cr-Commit-Position: refs/heads/master@{#421553}

Patch Set 1 #

Patch Set 2 : Adjust thresholds for mac. #

Patch Set 3 : Adjust thresholds for mac. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-fftsize-reset.html View 1 2 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Raymond Toy
PTAL
4 years, 3 months ago (2016-09-16 21:57:53 UTC) #2
hongchan
lgtm
4 years, 3 months ago (2016-09-16 22:31:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344353002/40001
4 years, 2 months ago (2016-09-28 16:14:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 17:18:17 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 17:21:16 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/647f68a193fdf3a1eeb26fd51badf0bffeb18edc
Cr-Commit-Position: refs/heads/master@{#421553}

Powered by Google App Engine
This is Rietveld 408576698