Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2344313002: Make bot_update.py print git version it uses. (Closed)

Created:
4 years, 3 months ago by Vadim Sh.
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Vadim Sh.
4 years, 3 months ago (2016-09-16 19:35:59 UTC) #1
Ryan Tseng
lgtm
4 years, 3 months ago (2016-09-16 19:38:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344313002/1
4 years, 3 months ago (2016-09-16 19:39:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/314d54dffb48b310)
4 years, 3 months ago (2016-09-16 19:45:44 UTC) #7
estaab
lgtm
4 years, 3 months ago (2016-09-16 19:47:35 UTC) #9
tandrii(chromium)
lgtm how come Ryan isn't an OWNER?
4 years, 3 months ago (2016-09-16 19:48:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344313002/1
4 years, 3 months ago (2016-09-16 19:48:54 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/6ac12ffd596e338c43e25dc3889e8ac552c2e885
4 years, 3 months ago (2016-09-16 19:51:51 UTC) #15
Ryan Tseng
4 years, 3 months ago (2016-09-16 19:53:29 UTC) #16
Message was sent while issue was closed.
I think it's the google/chromium account dichotomy :(

I should've stamped it with my other browser window instead

Powered by Google App Engine
This is Rietveld 408576698