Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 23443009: [Android] Support startup histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [Android] Support startup histogram - move new android source and fix nits. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_main_delegate.cc
diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc
index bdab589108971e448cbdd9053a0420ed28be536e..cc0c1b1c21bb43506d607a7eff4eb0d75aafe36d 100644
--- a/chrome/app/chrome_main_delegate.cc
+++ b/chrome/app/chrome_main_delegate.cc
@@ -340,7 +340,15 @@ struct MainFunction {
} // namespace
ChromeMainDelegate::ChromeMainDelegate() {
+#if !defined(OS_ANDROID)
jam 2013/08/29 15:16:17 nit: this would be slightly easier to read if the
aberent 2013/08/29 16:19:44 Done.
startup_metric_utils::RecordMainEntryPointTime();
+#else
+// On Android the main entry point time is the time when the Java code starts.
+// This happens before the shared library containing this code is even loaded.
+// The Java startup code has recorded that time, but the C++ code can't fetch it
+// from the Java side until it has initialized the JNI. See
+// ChromeMainDelegateAndroid.
+#endif
}
ChromeMainDelegate::~ChromeMainDelegate() {

Powered by Google App Engine
This is Rietveld 408576698