Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 23443009: [Android] Support startup histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [Android] Support startup histogram; remove unnecessary change to AwShellApplication.java Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index e8612a18a4d7a25953c8afaf9187d781462b4dd1..10244ec4dfaf97fe960c6c46a1d3c93d75504c18 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -686,7 +686,14 @@ void ChromeBrowserMainParts::RecordBrowserStartupTime() {
if (startup_metric_utils::WasNonBrowserUIDisplayed())
return;
+#if !defined(OS_ANDROID)
bool is_first_run = first_run::IsChromeFirstRun();
+#else
+ // On Android the first run is handled very differently, and the C++ doesn't
jeremy 2013/08/27 19:18:51 nit: C++ -> "C++ side of things"
aberent 2013/08/28 15:53:05 Done.
+ // know if this is the first run. This will cause some inaccuracy in the UMA
+ // statistics, but this should be minor (first runs are rare).
+ bool is_first_run = false;
+#endif
// CurrentProcessInfo::CreationTime() is currently only implemented on some
// platforms.
@@ -1595,7 +1602,14 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
delete parameters().ui_task;
run_message_loop_ = false;
}
-
+#if defined(OS_ANDROID)
+ // We never run the C++ main loop on Android, since the UI thread message
+ // loop is controlled by the OS, so this is as close as we can get to
+ // the start of the main loop
+ if (result_code_ <= 0) {
+ RecordBrowserStartupTime();
+ }
+#endif
return result_code_;
}

Powered by Google App Engine
This is Rietveld 408576698