chrome/app/chrome_main_delegate.cc - Issue 23443009: [Android] Support startup histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 23443009: [Android] Support startup histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [Android] Support startup histogram - answer code review comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/chrome_main_delegate.cc

diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc

index bdab589108971e448cbdd9053a0420ed28be536e..15ff230ccb18b5dd2fc48cb747e4f3569f117f8f 100644

--- a/chrome/app/chrome_main_delegate.cc

+++ b/chrome/app/chrome_main_delegate.cc

@@ -340,7 +340,13 @@ struct MainFunction {

} // namespace

ChromeMainDelegate::ChromeMainDelegate() {

+#if !defined(OS_ANDROID)

startup_metric_utils::RecordMainEntryPointTime();

+#else

+// On Android the main entry point time is when the Java code starts, not here.

jeremy 2013/08/28 18:15:56 nit: not here -> this happens before the C++ side

aberent 2013/08/29 11:45:13 Done.

+// The Java side has recorded that, but the C++ side can't fetch it from the

+// Java side until we have initialized the JNI. See ChromeMainDelegateAndroid.

+#endif

}

ChromeMainDelegate::~ChromeMainDelegate() {