Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: extensions/browser/api/vpn_provider/vpn_service.h

Issue 2344273002: Remove stl_util's STLDeleteContainerPairSecondPointers from extensions. (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/vpn_provider/vpn_service.h
diff --git a/extensions/browser/api/vpn_provider/vpn_service.h b/extensions/browser/api/vpn_provider/vpn_service.h
index 664c0cc538dfe5b06d76494ae89e7f1a41e060c2..7deaaa9e83f32dec549fcd47acc48589124d6987 100644
--- a/extensions/browser/api/vpn_provider/vpn_service.h
+++ b/extensions/browser/api/vpn_provider/vpn_service.h
@@ -173,6 +173,8 @@ class VpnService : public KeyedService,
class VpnServiceProxyImpl;
using StringToConfigurationMap = std::map<std::string, VpnConfiguration*>;
+ using StringToOwnedConfigurationMap =
+ std::map<std::string, std::unique_ptr<VpnConfiguration>>;
// Callback used to indicate that configuration was successfully created.
void OnCreateConfigurationSuccess(const SuccessCallback& callback,
@@ -254,7 +256,7 @@ class VpnService : public KeyedService,
VpnConfiguration* active_configuration_;
// Key map owns the VpnConfigurations.
Devlin 2016/09/16 20:23:19 This comment should be unnecessary now.
Avi (use Gerrit) 2016/09/16 20:41:45 Done.
- StringToConfigurationMap key_to_configuration_map_;
+ StringToOwnedConfigurationMap key_to_configuration_map_;
// Service path does not own the VpnConfigurations.
StringToConfigurationMap service_path_to_configuration_map_;

Powered by Google App Engine
This is Rietveld 408576698