Remove stl_util's STLDeleteContainerPairSecondPointers from extensions.

Remove stl_util's STLDeleteContainerPairSecondPointers from extensions.

BUG=555865
Committed: https://crrev.com/9ccd64ffc314e69b71c2a22552bfe9c73249be1e
Cr-Commit-Position: refs/heads/master@{#419297}

[Avi (use Gerrit), 2016-09-16 18:51:43]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 18:52:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 19:02:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:02:50]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Avi (use Gerrit), 2016-09-16 19:13:32]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 19:13:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-16 19:53:43]

avi@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:54:54]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-16 20:23:20]

lgtm

https://codereview.chromium.org/2344273002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/messaging/message_service.cc (right):

https://codereview.chromium.org/2344273002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/messaging/message_service.cc:592: MessageChannel*
channel = channel_ptr.get();
optional nit: maybe rename to "raw_channel"?

https://codereview.chromium.org/2344273002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/messaging/message_service.h (right):

https://codereview.chromium.org/2344273002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/messaging/message_service.h:188: typedef
std::map<int, std::unique_ptr<MessageChannel>> MessageChannelMap;
nit: update to 'using' syntax since we're here?

https://codereview.chromium.org/2344273002/diff/20001/extensions/browser/api/...
File extensions/browser/api/vpn_provider/vpn_service.h (right):

https://codereview.chromium.org/2344273002/diff/20001/extensions/browser/api/...
extensions/browser/api/vpn_provider/vpn_service.h:258: // Key map owns the
VpnConfigurations.
This comment should be unnecessary now.

[Avi (use Gerrit), 2016-09-16 20:41:24]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-09-16 20:41:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2344273002/#ps40001
(title: "devlin")

[Avi (use Gerrit), 2016-09-16 20:41:45]

https://codereview.chromium.org/2344273002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/messaging/message_service.cc (right):

https://codereview.chromium.org/2344273002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/messaging/message_service.cc:592: MessageChannel*
channel = channel_ptr.get();
On 2016/09/16 20:23:19, Devlin wrote:
> optional nit: maybe rename to "raw_channel"?

I'll pass.

That's used for the rest of the function to refer to the channel, while the
owning pointer is passed off to the AddChannel() function immediately.
Therefore, I'm giving the raw pointer the better name.

https://codereview.chromium.org/2344273002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/messaging/message_service.h (right):

https://codereview.chromium.org/2344273002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/messaging/message_service.h:188: typedef
std::map<int, std::unique_ptr<MessageChannel>> MessageChannelMap;
On 2016/09/16 20:23:19, Devlin wrote:
> nit: update to 'using' syntax since we're here?

Done.

https://codereview.chromium.org/2344273002/diff/20001/extensions/browser/api/...
File extensions/browser/api/vpn_provider/vpn_service.h (right):

https://codereview.chromium.org/2344273002/diff/20001/extensions/browser/api/...
extensions/browser/api/vpn_provider/vpn_service.h:258: // Key map owns the
VpnConfigurations.
On 2016/09/16 20:23:19, Devlin wrote:
> This comment should be unnecessary now.

Done.

[commit-bot: I haz the power, 2016-09-16 20:41:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:16:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 22:19:38]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from extensions.

BUG=555865
==========

to

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from extensions.

BUG=555865

Committed: https://crrev.com/9ccd64ffc314e69b71c2a22552bfe9c73249be1e
Cr-Commit-Position: refs/heads/master@{#419297}
==========

[commit-bot: I haz the power, 2016-09-16 22:19:39]

Patchset 3 (id:??) landed as
https://crrev.com/9ccd64ffc314e69b71c2a22552bfe9c73249be1e
Cr-Commit-Position: refs/heads/master@{#419297}