Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2344263002: Fix bad commit of stale patch set of original CL "Make NoReloadScope thread safe" (Closed)

Created:
4 years, 3 months ago by Cutch
Modified:
4 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bad commit of stale patch set of original CL "Make NoReloadScope thread safe" (https://codereview.chromium.org/2344193002/) BUG= Committed: https://github.com/dart-lang/sdk/commit/b961fc01ade0d303c06d0c06b8682f574475669e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -5 lines) Patch
M runtime/vm/atomic.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/atomic_android.h View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/atomic_fuchsia.h View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/atomic_linux.h View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/atomic_macos.h View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/atomic_win.h View 2 chunks +26 lines, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
TBR
4 years, 3 months ago (2016-09-16 18:33:16 UTC) #4
Cutch
Committed patchset #1 (id:1) manually as b961fc01ade0d303c06d0c06b8682f574475669e (presubmit successful).
4 years, 3 months ago (2016-09-16 18:33:49 UTC) #6
Florian Schneider
4 years, 3 months ago (2016-09-16 19:30:37 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698