Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2344223002: Revert of Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly (Closed)

Created:
4 years, 3 months ago by afakhry
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly (patchset #1 id:1 of https://codereview.chromium.org/2349603002/ ) Reason for revert: Breaks BuildPackages due to GN error (https://bugs.chromium.org/p/chromium/issues/detail?id=647706). BUG=647706 Original issue's description: > Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly > > Committed: https://crrev.com/ca5b9cba81bf335ce205cc06e094587b25c79758 > Cr-Commit-Position: refs/heads/master@{#419168} TBR=dpranke@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a07b9abadda659da084e94fc2a6a2d45da52a7a5 Cr-Commit-Position: refs/heads/master@{#419190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/BUILD.gn View 2 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
afakhry
Created Revert of Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly
4 years, 3 months ago (2016-09-16 16:47:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344223002/1
4 years, 3 months ago (2016-09-16 16:48:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 16:49:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a07b9abadda659da084e94fc2a6a2d45da52a7a5 Cr-Commit-Position: refs/heads/master@{#419190}
4 years, 3 months ago (2016-09-16 16:51:06 UTC) #7
Dirk Pranke
4 years, 3 months ago (2016-09-16 16:55:38 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698