Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2344203002: Site Settings Desktop: Minor fix. (Closed)

Created:
4 years, 3 months ago by Finnur
Modified:
4 years, 3 months ago
Reviewers:
dschuyler, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Minor fix. Use preprocess=true instead of flattenhtml and allowexternalscript. BUG=635850 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/40e215ad73339ab39c468105c31cc056906d3e01 Cr-Commit-Position: refs/heads/master@{#419429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Finnur
4 years, 3 months ago (2016-09-16 14:19:49 UTC) #3
Dan Beam
lgtm
4 years, 3 months ago (2016-09-16 15:59:16 UTC) #5
dschuyler
lgtm
4 years, 3 months ago (2016-09-16 17:38:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344203002/1
4 years, 3 months ago (2016-09-19 10:35:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 11:13:58 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 11:16:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40e215ad73339ab39c468105c31cc056906d3e01
Cr-Commit-Position: refs/heads/master@{#419429}

Powered by Google App Engine
This is Rietveld 408576698