Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 23442019: Convert most run_all_unittests.cc files to use new unit test launcher. (Closed)

Created:
7 years, 3 months ago by Paweł Hajdan Jr.
Modified:
7 years, 3 months ago
CC:
chromium-reviews, jbauman+watch_chromium.org, cbentzel+watch_chromium.org, sadrul, ben+watch_chromium.org, Ian Vollick, tfarina, jam, sievers+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Convert most run_all_unittests.cc files to use new unit test launcher. Note that the new code is still behind a runtime flag (--brave-new-test-launcher), but compiling tests with support for it will make further testing possible. BUG=236893, 79359 R=akalin@chromium.org, enne@chromium.org, erikwright@chromium.org, joi@chromium.org, keybuk@chromium.org, sky@chromium.org, thestig@chromium.org, tommi@chromium.org, wtc@chromium.org, xhwang@chromium.org, yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221464

Patch Set 1 #

Total comments: 3

Patch Set 2 : typo #

Patch Set 3 : trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -138 lines) Patch
M cc/test/run_all_unittests.cc View 1 chunk +5 lines, -2 lines 0 comments Download
D chrome/app/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/run_all_unittests.cc View 1 chunk +7 lines, -1 line 0 comments Download
M components/test/run_all_unittests.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/test/run_all_unittests.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M courgette/courgette.gyp View 2 chunks +1 line, -1 line 0 comments Download
D courgette/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M crypto/crypto.gyp View 2 chunks +1 line, -4 lines 0 comments Download
D crypto/run_all_unittests.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M device/device_tests.gyp View 2 chunks +1 line, -1 line 0 comments Download
D device/test/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M jingle/jingle.gyp View 2 chunks +1 line, -1 line 0 comments Download
D jingle/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M media/base/run_all_unittests.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M net/test/run_all_unittests.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 2 chunks +1 line, -2 lines 0 comments Download
D ppapi/proxy/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M printing/printing.gyp View 2 chunks +1 line, -2 lines 0 comments Download
D printing/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D sql/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M sql/sql.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/run_all_unittests.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ui/compositor/run_all_unittests.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ui/message_center/test/run_all_unittests.cc View 1 chunk +7 lines, -28 lines 0 comments Download
M ui/snapshot/test/run_all_unittests.cc View 1 2 1 chunk +28 lines, -2 lines 0 comments Download
M ui/test/run_all_unittests.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ui/views/run_all_unittests.cc View 2 chunks +7 lines, -1 line 0 comments Download
M webkit/renderer/compositor_bindings/test/run_all_unittests.cc View 1 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Paweł Hajdan Jr.
Please review (simple changes, let me know if you have questions; there are no changes ...
7 years, 3 months ago (2013-09-03 23:10:49 UTC) #1
akalin
jingle lgtm
7 years, 3 months ago (2013-09-03 23:12:09 UTC) #2
xhwang
media/ lgtm
7 years, 3 months ago (2013-09-03 23:12:39 UTC) #3
keybuk
device/ lgtm
7 years, 3 months ago (2013-09-03 23:13:28 UTC) #4
yzshen1
On 2013/09/03 23:13:28, keybuk wrote: > device/ lgtm ppapi/ lgtm Thanks!
7 years, 3 months ago (2013-09-03 23:18:28 UTC) #5
enne (OOO)
cc/ lgtm
7 years, 3 months ago (2013-09-03 23:19:22 UTC) #6
Lei Zhang
printing lgtm
7 years, 3 months ago (2013-09-03 23:19:33 UTC) #7
enne (OOO)
webkit/renderer/compositor_bindings/ also lgtm https://codereview.chromium.org/23442019/diff/1/webkit/renderer/compositor_bindings/test/run_all_unittests.cc File webkit/renderer/compositor_bindings/test/run_all_unittests.cc (right): https://codereview.chromium.org/23442019/diff/1/webkit/renderer/compositor_bindings/test/run_all_unittests.cc#newcode18 webkit/renderer/compositor_bindings/test/run_all_unittests.cc:18: } // nemespace typo
7 years, 3 months ago (2013-09-03 23:21:04 UTC) #8
tommi (sloooow) - chröme
courgette/ lgtm
7 years, 3 months ago (2013-09-04 06:57:32 UTC) #9
Jói
//components LGTM.
7 years, 3 months ago (2013-09-04 07:30:14 UTC) #10
erikwright (departed)
sql/ LGTM.
7 years, 3 months ago (2013-09-04 14:34:32 UTC) #11
sky
LGTM
7 years, 3 months ago (2013-09-04 16:38:30 UTC) #12
wtc
crypto and net LGTM. https://codereview.chromium.org/23442019/diff/1/crypto/run_all_unittests.cc File crypto/run_all_unittests.cc (left): https://codereview.chromium.org/23442019/diff/1/crypto/run_all_unittests.cc#oldcode12 crypto/run_all_unittests.cc:12: // TODO(rvargas) Bug 79359: remove ...
7 years, 3 months ago (2013-09-04 18:29:33 UTC) #13
sky
LGTM
7 years, 3 months ago (2013-09-05 16:20:14 UTC) #14
Paweł Hajdan Jr.
https://codereview.chromium.org/23442019/diff/1/webkit/renderer/compositor_bindings/test/run_all_unittests.cc File webkit/renderer/compositor_bindings/test/run_all_unittests.cc (right): https://codereview.chromium.org/23442019/diff/1/webkit/renderer/compositor_bindings/test/run_all_unittests.cc#newcode18 webkit/renderer/compositor_bindings/test/run_all_unittests.cc:18: } // nemespace On 2013/09/03 23:21:04, enne wrote: > ...
7 years, 3 months ago (2013-09-05 18:20:04 UTC) #15
Paweł Hajdan Jr.
7 years, 3 months ago (2013-09-05 18:20:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 manually as r221464 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698