Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2614)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/isolate.h

Issue 2344193002: Make NoReloadScope thread safe (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/atomic.h ('K') | « runtime/vm/atomic.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 12dd5fa2f6fdcc37fd861a2de0c6adc4eb08164f..4d4032c43b8c78c140384b526084c08c957cd6bb 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -823,7 +823,7 @@ class Isolate : public BaseIsolate {
// Has a reload ever been attempted?
bool has_attempted_reload_;
- intptr_t no_reload_scope_depth_; // we can only reload when this is 0.
+ uintptr_t no_reload_scope_depth_; // we can only reload when this is 0.
Florian Schneider 2016/09/16 16:22:41 What is the reason for using uintptr_t?
Cutch 2016/09/16 16:45:30 Because the AtomicOperations I need are typed for
// Per-isolate copy of FLAG_reload_every.
intptr_t reload_every_n_stack_overflow_checks_;
IsolateReloadContext* reload_context_;
« runtime/vm/atomic.h ('K') | « runtime/vm/atomic.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698