Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2344163002: Updating swarming dimensions to add the Chrome-perf pool. (Closed)

Created:
4 years, 3 months ago by eyaich1
Modified:
4 years, 3 months ago
Reviewers:
sullivan, dtu, M-A Ruel
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating swarming dimensions to add the Chrome-perf pool. BUG=chromium:633253 Committed: https://crrev.com/d6bbb20e714069893433d53f8beda29b8a2a95b2 Cr-Commit-Position: refs/heads/master@{#419160}

Patch Set 1 #

Patch Set 2 : Fixing copy paste error #

Total comments: 2

Patch Set 3 : Adding trailing comm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -21 lines) Patch
M testing/buildbot/chromium.perf.fyi.json View 1 10 chunks +40 lines, -20 lines 0 comments Download
M tools/perf/generate_perf_json.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
eyaich1
4 years, 3 months ago (2016-09-16 13:16:16 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/2344163002/diff/20001/tools/perf/generate_perf_json.py File tools/perf/generate_perf_json.py (right): https://codereview.chromium.org/2344163002/diff/20001/tools/perf/generate_perf_json.py#newcode202 tools/perf/generate_perf_json.py:202: 'pool': 'Chrome-perf' add trailing comma here too. When ...
4 years, 3 months ago (2016-09-16 13:20:42 UTC) #4
eyaich1
https://codereview.chromium.org/2344163002/diff/20001/tools/perf/generate_perf_json.py File tools/perf/generate_perf_json.py (right): https://codereview.chromium.org/2344163002/diff/20001/tools/perf/generate_perf_json.py#newcode202 tools/perf/generate_perf_json.py:202: 'pool': 'Chrome-perf' On 2016/09/16 13:20:42, M-A Ruel wrote: > ...
4 years, 3 months ago (2016-09-16 13:22:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344163002/40001
4 years, 3 months ago (2016-09-16 13:22:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/261012)
4 years, 3 months ago (2016-09-16 13:30:23 UTC) #10
sullivan
lgtm
4 years, 3 months ago (2016-09-16 13:37:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344163002/40001
4 years, 3 months ago (2016-09-16 13:38:10 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 14:20:34 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 14:22:30 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d6bbb20e714069893433d53f8beda29b8a2a95b2
Cr-Commit-Position: refs/heads/master@{#419160}

Powered by Google App Engine
This is Rietveld 408576698