chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm - Issue 2344133003: Add help link when Bluetooth adapter is off for WebBluetooth chooser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

Issue 2344133003: Add help link when Bluetooth adapter is off for WebBluetooth chooser (Closed)

Patch Set: address more comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chooser_controller/chooser_controller.cc ('K') | « chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc ('k') | chrome/browser/ui/views/chooser_content_view.h » ('j') | chrome/browser/ui/views/chooser_content_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

index a4ccce77ec73ae1cf18796fdae493a8d490244eb..7511679d4c2925f14827920ce3d96092841ff1f3 100644

--- a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

@@ -929,8 +929,9 @@ TEST_F(ChooserDialogCocoaControllerTest, AdapterOnAndOffAndOn) {

// No option selected.

EXPECT_EQ(-1, table_view_.selectedRow);

ExpectNoRowImage(0);

- ExpectRowTextIs(

- 0, l10n_util::GetNSString(IDS_BLUETOOTH_DEVICE_CHOOSER_ADAPTER_OFF));

+ // TODO(juncai): test the row text is "Turn on Bluetooth to allow pairing"

+ // after the Mac implementation is done.

+ // https://crbug.com/644168

EXPECT_FALSE(IsRowPaired(0));

EXPECT_TRUE(spinner_.hidden);

EXPECT_TRUE(status_.hidden);