Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: chrome/renderer/extensions/pepper_request_natives.cc

Issue 234413005: Move most of ChromeV8Context to a base ScriptContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/pepper_request_natives.cc
diff --git a/chrome/renderer/extensions/pepper_request_natives.cc b/chrome/renderer/extensions/pepper_request_natives.cc
index fde2a14bc77e4d19173161a8999e56f555e9e2fc..3cde00a69517221bd3232514b24c4d2a9a4ebe53 100644
--- a/chrome/renderer/extensions/pepper_request_natives.cc
+++ b/chrome/renderer/extensions/pepper_request_natives.cc
@@ -26,8 +26,9 @@ void PepperRequestNatives::SendResponse(
DCHECK(args[0]->IsInt32());
DCHECK(args[1]->IsArray());
int request_id = args[0]->Int32Value();
+ ChromeV8Context* chrome_context = static_cast<ChromeV8Context*>(context());
not at google - send to devlin 2014/04/11 15:38:55 could you add a note here explaining this? maybe f
Ken Rockot(use gerrit already) 2014/04/11 17:02:18 Done.
if (args[2]->IsString()) {
- context()->pepper_request_proxy()->OnResponseReceived(
+ chrome_context->pepper_request_proxy()->OnResponseReceived(
request_id, false, base::ListValue(), *v8::String::Utf8Value(args[2]));
return;
}
@@ -35,11 +36,11 @@ void PepperRequestNatives::SendResponse(
scoped_ptr<content::V8ValueConverter> converter(
content::V8ValueConverter::create());
scoped_ptr<const base::Value> result(
- converter->FromV8Value(args[1], context()->v8_context()));
+ converter->FromV8Value(args[1], chrome_context->v8_context()));
DCHECK(result);
const base::ListValue* result_list = NULL;
CHECK(result->GetAsList(&result_list));
- context()->pepper_request_proxy()->OnResponseReceived(
+ chrome_context->pepper_request_proxy()->OnResponseReceived(
request_id, true, *result_list, "");
}

Powered by Google App Engine
This is Rietveld 408576698