Move most of ChromeV8Context to a base ScriptContext

extensions/renderer/console.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/renderer/extensions/console.h"
+#include "extensions/renderer/console.h"
 
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
 #include "base/lazy_instance.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/renderer/extensions/dispatcher.h"
 #include "chrome/renderer/extensions/extension_helper.h"
 #include "content/public/renderer/render_view.h"
@@ skipping 12 matching lines @@
 class ByContextFinder : public content::RenderViewVisitor {
  public:
   static content::RenderView* Find(v8::Handle<v8::Context> context) {
     ByContextFinder finder(context);
     content::RenderView::ForEach(&finder);
     return finder.found_;
   }
 
  private:
   explicit ByContextFinder(v8::Handle<v8::Context> context)
-      : context_(context), found_(NULL) {
-  }
+      : context_(context), found_(NULL) {}
 
   virtual bool Visit(content::RenderView* render_view) OVERRIDE {
     ExtensionHelper* helper = ExtensionHelper::Get(render_view);
     if (helper &&
         helper->dispatcher()->v8_context_set().GetByV8Context(context_)) {

[not at google - send to devlin, 2014/04/11 15:38:55]

cool. it seems like you should eventually be able to pull dispatcher out of the
equation here and remove the chrome dependencies easily enough.

       found_ = render_view;
     }
     return !found_;
   }
 
   v8::Handle<v8::Context> context_;
   content::RenderView* found_;
 
   DISALLOW_COPY_AND_ASSIGN(ByContextFinder);
 };
 
 // Writes |message| to stack to show up in minidump, then crashes.
 void CheckWithMinidump(const std::string& message) {
   char minidump[1024];
   base::debug::Alias(&minidump);
-  base::snprintf(minidump, arraysize(minidump),
-                 "e::console: %s", message.c_str());
+  base::snprintf(
+      minidump, arraysize(minidump), "e::console: %s", message.c_str());
   CHECK(false) << message;
 }
 
 typedef void (*LogMethod)(v8::Handle<v8::Context> context,
                           const std::string& message);
 
 void BoundLogMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
-  LogMethod log_method = reinterpret_cast<LogMethod>(
-      info.Data().As<v8::External>()->Value());
+  LogMethod log_method =
+      reinterpret_cast<LogMethod>(info.Data().As<v8::External>()->Value());
   std::string message;
   for (int i = 0; i < info.Length(); ++i) {
     if (i > 0)
       message += " ";
     message += *v8::String::Utf8Value(info[i]);
   }
   (*log_method)(info.GetIsolate()->GetCallingContext(), message);
 }
 
 void BindLogMethod(v8::Isolate* isolate,
@@ skipping 99 matching lines @@
   v8::Local<v8::Object> console_object = v8::Object::New(isolate);
   BindLogMethod(isolate, console_object, "debug", &Debug);
   BindLogMethod(isolate, console_object, "log", &Log);
   BindLogMethod(isolate, console_object, "warn", &Warn);
   BindLogMethod(isolate, console_object, "error", &Error);
   return handle_scope.Escape(console_object);
 }
 
 }  // namespace console
 }  // namespace extensions