Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: PRESUBMIT.py

Issue 234413005: Move most of ChromeV8Context to a base ScriptContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 r'^ppapi[\\\/]tests[\\\/]test_broker\.cc$', 233 r'^ppapi[\\\/]tests[\\\/]test_broker\.cc$',
234 ), 234 ),
235 ), 235 ),
236 ( 236 (
237 r'/v8::Extension\(', 237 r'/v8::Extension\(',
238 ( 238 (
239 'Do not introduce new v8::Extensions into the code base, use', 239 'Do not introduce new v8::Extensions into the code base, use',
240 'gin::Wrappable instead. See http://crbug.com/334679', 240 'gin::Wrappable instead. See http://crbug.com/334679',
241 ), 241 ),
242 True, 242 True,
243 (), 243 (
244 r'extensions[/\\]renderer[/\\]safe_builtins\.*',
not at google - send to devlin 2014/04/11 15:38:55 what does this change mean?
Ken Rockot(use gerrit already) 2014/04/11 17:02:18 It's a whitelist for the moved code. Spoke with jo
245 ),
244 ), 246 ),
245 ) 247 )
246 248
247 249
248 _VALID_OS_MACROS = ( 250 _VALID_OS_MACROS = (
249 # Please keep sorted. 251 # Please keep sorted.
250 'OS_ANDROID', 252 'OS_ANDROID',
251 'OS_ANDROID_HOST', 253 'OS_ANDROID_HOST',
252 'OS_BSD', 254 'OS_BSD',
253 'OS_CAT', # For testing. 255 'OS_CAT', # For testing.
(...skipping 1215 matching lines...) Expand 10 before | Expand all | Expand 10 after
1469 builders.extend(['cros_x86']) 1471 builders.extend(['cros_x86'])
1470 1472
1471 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1473 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1472 # unless they're .gyp(i) files as changes to those files can break the gyp 1474 # unless they're .gyp(i) files as changes to those files can break the gyp
1473 # step on that bot. 1475 # step on that bot.
1474 if (not all(re.search('^chrome', f) for f in files) or 1476 if (not all(re.search('^chrome', f) for f in files) or
1475 any(re.search('\.gypi?$', f) for f in files)): 1477 any(re.search('\.gypi?$', f) for f in files)):
1476 builders.extend(['android_aosp']) 1478 builders.extend(['android_aosp'])
1477 1479
1478 return GetDefaultTryConfigs(builders) 1480 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_renderer.gypi » ('j') | chrome/renderer/extensions/chrome_v8_context.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698