Fix DevTools showCertificateViewer to use visible entry

Fix DevTools showCertificateViewer to use visible entry

When the Security.showCertificateViewer command is received by the
browser, it should show the certificate for the visible entry, not
necessarily the last committed entry, because there might be a transient
entry for an interstitial overlaying the last committed entry.

BUG=647759
Committed: https://crrev.com/b056baab94111806630ff183834064a461906e42
Cr-Commit-Position: refs/heads/master@{#419359}

[estark, 2016-09-16 21:55:42]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[estark, 2016-09-16 21:56:21]

estark@chromium.org changed reviewers:
+ jam@chromium.org

[estark, 2016-09-16 21:56:22]

jam, PTAL?

[commit-bot: I haz the power, 2016-09-16 21:56:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-16 22:00:59]

lgtm, thanks

[pfeldman, 2016-09-16 22:03:56]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-09-16 22:03:57]

https://codereview.chromium.org/2344113003/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2344113003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:997:
TestInterstitialDelegate* delegate = new TestInterstitialDelegate;
I am not familiar with this code, but I don't see where InterstitialPageImpl
takes ownership of this delegate.

[estark, 2016-09-16 22:06:12]

https://codereview.chromium.org/2344113003/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2344113003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:997:
TestInterstitialDelegate* delegate = new TestInterstitialDelegate;
On 2016/09/16 22:03:57, pfeldman wrote:
> I am not familiar with this code, but I don't see where InterstitialPageImpl
> takes ownership of this delegate.

It get passed in as an argument to the InterstitialPageImpl constructor (line
1003), which stuffs it into a unique_ptr |delegate_| member:
https://cs.chromium.org/chromium/src/content/browser/frame_host/interstitial_...

[pfeldman, 2016-09-16 22:07:32]

Oh, good, I was looking at render_widget_host_delegate next to it that was raw!

[commit-bot: I haz the power, 2016-09-16 22:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:20:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[estark, 2016-09-16 23:08:47]

The CQ bit was checked by estark@chromium.org

[estark, 2016-09-16 23:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2344113003/#ps20001
(title: "load test certs in SetUpOnMainThread")

[commit-bot: I haz the power, 2016-09-16 23:09:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:13:27]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estark, 2016-09-16 23:15:40]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:16:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:19:00]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[estark, 2016-09-17 00:33:47]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-09-17 00:34:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 01:19:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-17 01:22:13]

Description was changed from

==========
Fix DevTools showCertificateViewer to use visible entry

When the Security.showCertificateViewer command is received by the
browser, it should show the certificate for the visible entry, not
necessarily the last committed entry, because there might be a transient
entry for an interstitial overlaying the last committed entry.

BUG=647759
==========

to

==========
Fix DevTools showCertificateViewer to use visible entry

When the Security.showCertificateViewer command is received by the
browser, it should show the certificate for the visible entry, not
necessarily the last committed entry, because there might be a transient
entry for an interstitial overlaying the last committed entry.

BUG=647759

Committed: https://crrev.com/b056baab94111806630ff183834064a461906e42
Cr-Commit-Position: refs/heads/master@{#419359}
==========

[commit-bot: I haz the power, 2016-09-17 01:22:14]

Patchset 2 (id:??) landed as
https://crrev.com/b056baab94111806630ff183834064a461906e42
Cr-Commit-Position: refs/heads/master@{#419359}