Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2344113002: Parse 'starred' attribute to FileLables in DriveAPI. (Closed)

Created:
4 years, 3 months ago by harukam
Modified:
4 years, 3 months ago
Reviewers:
fukino, kinaba
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse 'starred' attribute to FileLables in DriveAPI. Additionally parsing 'starred' attribute is necessary in order to implement showing 'starred' icon for Files app. BUG=646839 TEST=google_apis_unittests --gtest_filter=DriveAPIParserTest.FileListParser Committed: https://crrev.com/930f5e4f70364038b391654606445005bd65df27 Cr-Commit-Position: refs/heads/master@{#419097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M google_apis/drive/drive_api_parser.h View 2 chunks +4 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_parser.cc View 3 chunks +5 lines, -1 line 0 comments Download
M google_apis/drive/drive_api_parser_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
harukam
fukino-san, PTAL.
4 years, 3 months ago (2016-09-16 01:47:35 UTC) #2
fukino
looking good. Adding kinaba@ san as an OWNER reviewer.
4 years, 3 months ago (2016-09-16 02:30:45 UTC) #4
kinaba
lgtm
4 years, 3 months ago (2016-09-16 02:45:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344113002/1
4 years, 3 months ago (2016-09-16 03:30:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 04:21:53 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 04:24:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/930f5e4f70364038b391654606445005bd65df27
Cr-Commit-Position: refs/heads/master@{#419097}

Powered by Google App Engine
This is Rietveld 408576698