Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23441085: Expose chrome, devices, and help Chrome URL hosts. (Closed)

Created:
7 years, 3 months ago by msw
Modified:
7 years, 2 months ago
CC:
chromium-reviews, Noam Samuel, Vitaly Buka (NO REVIEWS)
Visibility:
Public.

Description

Expose chrome, devices, and help Chrome URL hosts. This will list these URLs in chrome://chrome-urls. They'll also be suggested in omnibox autocomplete. BUG=297421 R=pkasting@chromium.org TEST=chrome://chrome, chrome://devices, and chrome://help are all listed in about:chrome-urls and suggested in autocomplete. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/common/url_constants.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
msw
Hey Peter, please take a look; thanks!
7 years, 3 months ago (2013-09-24 20:05:37 UTC) #1
Peter Kasting
LGTM
7 years, 3 months ago (2013-09-24 20:27:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/23441085/1
7 years, 3 months ago (2013-09-24 20:44:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171354
7 years, 3 months ago (2013-09-24 22:11:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/23441085/1
7 years, 3 months ago (2013-09-24 22:15:31 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171561
7 years, 2 months ago (2013-09-25 02:46:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/23441085/1
7 years, 2 months ago (2013-09-25 03:03:05 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171716
7 years, 2 months ago (2013-09-25 05:55:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/23441085/1
7 years, 2 months ago (2013-09-25 13:40:08 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=158239
7 years, 2 months ago (2013-09-25 15:01:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/23441085/1
7 years, 2 months ago (2013-09-25 17:23:51 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=158410
7 years, 2 months ago (2013-09-25 18:56:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/23441085/1
7 years, 2 months ago (2013-09-25 22:50:10 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 04:08:14 UTC) #14
Message was sent while issue was closed. 
Change committed as 225317

Powered by Google App Engine
This is Rietveld 408576698