src/elements.cc - Issue 23441080: Correct large packed array length limitation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.cc

Issue 23441080: Correct large packed array length limitation (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: make consistent change Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.cc

diff --git a/src/elements.cc b/src/elements.cc

index 89621cb3694ad63288f5b1f9556326da5e02dcc5..fffd4701d38b45a3b418045cc39bbc68aadba2b7 100644

--- a/src/elements.cc

+++ b/src/elements.cc

@@ -1978,7 +1978,7 @@ MUST_USE_RESULT MaybeObject* ArrayConstructInitializeElements(

Object* obj = (*args)[0];

if (obj->IsSmi()) {

int len = Smi::cast(obj)->value();

- if (len > 0 && len < JSObject::kInitialMaxFastElementArray) {

+ if (len > 0 && len <= JSObject::kInitialMaxFastElementArray) {

ElementsKind elements_kind = array->GetElementsKind();

MaybeObject* maybe_array = array->Initialize(len, len);

if (maybe_array->IsFailure()) return maybe_array;

« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/runtime.cc » ('j') | no next file with comments »