src/code-stubs-hydrogen.cc - Issue 23441080: Correct large packed array length limitation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs-hydrogen.cc

Issue 23441080: Correct large packed array length limitation (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stubs-hydrogen.cc

diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc

index 0d06209b613db0f9dc46d32dbab532591edd720d..8496e80381bd927497f0f51b31d5dafe917a4e4a 100644

--- a/src/code-stubs-hydrogen.cc

+++ b/src/code-stubs-hydrogen.cc

@@ -661,7 +661,7 @@ HValue* CodeStubGraphBuilderBase::BuildArraySingleArgumentConstructor(

HConstant* initial_capacity_node = New<HConstant>(initial_capacity);

AddInstruction(initial_capacity_node);

- HInstruction* checked_arg = Add<HBoundsCheck>(argument, max_alloc_length);

+ HInstruction* checked_arg = Add<HBoundsCheck>(argument, max_alloc_length + 1);

Jakob Kummerow 2013/09/23 16:53:30 No way!

IfBuilder if_builder(this);

if_builder.If<HCompareNumericAndBranch>(checked_arg, constant_zero,

Token::EQ);

« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »