runtime/lib/mirrors_impl.dart - Issue 23441073: Implement closurization of regular methods in ObjectMirror.getField in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 23441073: Implement closurization of regular methods in ObjectMirror.getField in the VM. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/mirrors_impl.dart

diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart

index 0708da387279cf277b77e5779dc2123ae8068c60..e977653737ec927ca00664846cd12ad8100d683a 100644

--- a/runtime/lib/mirrors_impl.dart

+++ b/runtime/lib/mirrors_impl.dart

@@ -321,7 +321,6 @@ class _LocalInstanceMirrorImpl extends _LocalObjectMirrorImpl

InstanceMirror invoke(Symbol memberName,

List positionalArguments,

[Map<Symbol, dynamic> namedArguments]) {

int numPositionalArguments = positionalArguments.length + 1; // Receiver.

int numNamedArguments = namedArguments != null ? namedArguments.length : 0;

int numArguments = numPositionalArguments + numNamedArguments;

@@ -375,7 +374,6 @@ class _LocalClosureMirrorImpl extends _LocalInstanceMirrorImpl

// replaced with

// return this.invoke(#call, positionalArguments, namedArguments);

// and the native ClosureMirror_apply can be removed.

int numPositionalArguments = positionalArguments.length + 1; // Receiver.

int numNamedArguments = namedArguments != null ? namedArguments.length : 0;

int numArguments = numPositionalArguments + numNamedArguments;

« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »