Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 23441070: Test case of V8 failing to step into in some cases. (Closed)

Created:
7 years, 3 months ago by aandrey
Modified:
6 years, 3 months ago
Reviewers:
mvstanton, Yang, yurys
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Test case of V8 failing to step into in some cases. BUG=289497, v8:2888 R=yangguo@chromium.org, yurys@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24186

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -22 lines) Patch
A + test/mjsunit/debug-stepin-property-function-call.js View 1 2 3 chunks +97 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aandrey
7 years, 3 months ago (2013-09-16 14:57:53 UTC) #1
aandrey
Seems like the problem went away and we can commit the test. PTAL.
6 years, 3 months ago (2014-09-24 12:13:16 UTC) #3
Yang
Probably has something to do with the CallIC work mvstanton@ has been doing. LGTM with ...
6 years, 3 months ago (2014-09-24 12:16:29 UTC) #4
yurys
lgtm
6 years, 3 months ago (2014-09-24 12:24:29 UTC) #5
aandrey
https://codereview.chromium.org/23441070/diff/4001/test/mjsunit/debug-stepin-property-function-call.js File test/mjsunit/debug-stepin-property-function-call.js (right): https://codereview.chromium.org/23441070/diff/4001/test/mjsunit/debug-stepin-property-function-call.js#newcode45 test/mjsunit/debug-stepin-property-function-call.js:45: assertTrue(event_data.sourceLineText().indexOf("Expected to step") > 0, "source line: \"" + ...
6 years, 3 months ago (2014-09-24 13:16:06 UTC) #7
aandrey
6 years, 3 months ago (2014-09-24 14:52:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:24001) manually as 24186 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698