Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 23441069: Rebaseline "lighting" GM tests (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +1 line, -1 line 1 comment Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
epoger
https://codereview.chromium.org/23441069/diff/1/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json File expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json (right): https://codereview.chromium.org/23441069/diff/1/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json#newcode4331 expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json:4331: "lighting_565.png": { Generated like so: TESTNAME=lighting tools/rebaseline.py --tests $TESTNAME ...
7 years, 3 months ago (2013-09-13 20:36:05 UTC) #1
epoger
7 years, 3 months ago (2013-09-13 20:36:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r11271 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698