Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 23441062: Fix a crash by asynchronizing destruction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
index 2b4c207aebe5bbc601ad3c1b610fd6381f1b4558..15d0a42f39d07f97b26f11385cb7c740613d33e7 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
@@ -8,6 +8,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "chrome/browser/ui/views/website_settings/permission_selector_view_observer.h"
#include "chrome/browser/ui/website_settings/website_settings_ui.h"
@@ -114,6 +115,8 @@ class WebsiteSettingsPopupView
const string16& headline,
const string16& text,
views::Link* link);
+ // Handles LinkClicked asynchronously.
+ void HandleLinkClickedAsync(views::Link* source);
// The web contents of the current tab. The popup can't live longer than a
// tab.
@@ -159,6 +162,8 @@ class WebsiteSettingsPopupView
views::View* connection_info_content_;
views::View* page_info_content_;
+ base::WeakPtrFactory<WebsiteSettingsPopupView> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsPopupView);
};
« no previous file with comments | « no previous file | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698