DevTools: Improve design of WebViews available for inspection in chrome://inspect

chrome/browser/ui/webui/inspect_ui.cc

Index: chrome/browser/ui/webui/inspect_ui.cc
diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc
index fede447d8b7a9c3c921626b4b520e12521b13523..6d7230d159d7a6de9c212ae5fffa730711f3c207 100644
--- a/chrome/browser/ui/webui/inspect_ui.cc
+++ b/chrome/browser/ui/webui/inspect_ui.cc
@@ -105,6 +105,8 @@ static const char kAdbGlobalIdField[] = "adbGlobalId";
 static const char kAdbBrowsersField[] = "browsers";
 static const char kAdbPagesField[] = "pages";
 static const char kAdbPortStatus[] = "adbPortStatus";
+static const char kAdbScreenWidthField[] = "adbScreenWidth";
+static const char kAdbScreenHeightField[] = "adbScreenHeight";
 static const char kGuestList[] = "guests";
 
 DictionaryValue* BuildTargetDescriptor(
@@ -671,6 +673,8 @@ void InspectUI::RemoteDevicesChanged(
     DictionaryValue* device_data = new DictionaryValue();
     device_data->SetString(kAdbModelField, device->model());
     device_data->SetString(kAdbSerialField, device->serial());
+    device_data->SetInteger(kAdbScreenWidthField, device->screenWidth());
+    device_data->SetInteger(kAdbScreenHeightField, device->screenHeight());
     std::string device_id = base::StringPrintf(
         "device:%s",
         device->serial().c_str());
@@ -692,6 +696,11 @@ void InspectUI::RemoteDevicesChanged(
           browser->product().c_str(),  // Force sorting by product name.
           browser->socket().c_str());
       browser_data->SetString(kAdbGlobalIdField, browser_id);
+      // Pass the screen dimensions in the browser object as well to make sure

[pfeldman, 2013/09/13 13:38:41]

Please don't.

[Vladislav Kaznacheev, 2013/09/16 10:07:33]

Didn't
On 2013/09/13 13:38:41, pfeldman wrote:

+      // that the caching logic does not prevent page item from updating
+      // when the screen dimensions change.
+      browser_data->SetInteger(kAdbScreenWidthField, device->screenWidth());
+      browser_data->SetInteger(kAdbScreenHeightField, device->screenHeight());
       remote_browsers_[browser_id] = browser;
       ListValue* page_list = new ListValue();
       browser_data->Set(kAdbPagesField, page_list);