DevTools: Improve design of WebViews available for inspection in chrome://inspect

chrome/browser/ui/webui/inspect_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/inspect_ui.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 87 matching lines @@
 static const char kPidField[]  = "pid";
 static const char kAdbSerialField[] = "adbSerial";
 static const char kAdbModelField[] = "adbModel";
 static const char kAdbBrowserProductField[] = "adbBrowserProduct";
 static const char kAdbBrowserPackageField[] = "adbBrowserPackage";
 static const char kAdbBrowserVersionField[] = "adbBrowserVersion";
 static const char kAdbGlobalIdField[] = "adbGlobalId";
 static const char kAdbBrowsersField[] = "browsers";
 static const char kAdbPagesField[] = "pages";
 static const char kAdbPortStatus[] = "adbPortStatus";
+static const char kAdbScreenWidthField[] = "adbScreenWidth";
+static const char kAdbScreenHeightField[] = "adbScreenHeight";
 static const char kGuestList[] = "guests";
 
 DictionaryValue* BuildTargetDescriptor(
     const std::string& target_type,
     bool attached,
     const GURL& url,
     const std::string& name,
     const GURL& favicon_url,
     const std::string& description,
     int process_id,
@@ skipping 584 matching lines @@
         DevToolsAdbBridge::RemotePage* page =  it->get();
         DictionaryValue* page_data = BuildTargetDescriptor(
             kAdbTargetType, page->attached(),
             GURL(page->url()), page->title(), GURL(page->favicon_url()),
             page->description(), 0, 0);
         std::string page_id = base::StringPrintf("page:%s:%s:%s",
             device->serial().c_str(),
             browser->socket().c_str(),
             page->id().c_str());
         page_data->SetString(kAdbGlobalIdField, page_id);
+        // Pass the screen size in the page object to make sure that
+        // the caching logic does not prevent the page item from updating
+        // when the screen size changes.
+        gfx::Size screen_size = device->GetScreenSize();
+        page_data->SetInteger(kAdbScreenWidthField, screen_size.width());
+        page_data->SetInteger(kAdbScreenHeightField, screen_size.height());
         remote_pages_[page_id] = page;
         page_list->Append(page_data);
       }
       browser_list->Append(browser_data);
     }
 
     DictionaryValue* port_status_dict = new DictionaryValue();
     typedef DevToolsAdbBridge::RemoteDevice::PortStatusMap StatusMap;
     const StatusMap& port_status = device->port_status();
     for (StatusMap::const_iterator it = port_status.begin();
@@ skipping 49 matching lines @@
   base::DictionaryValue default_config;
   default_config.SetString(
       kPortForwardingDefaultPort, kPortForwardingDefaultLocation);
   prefs->Set(prefs::kDevToolsPortForwardingConfig, default_config);
 }
 
 const base::Value* InspectUI::GetPrefValue(const char* name) {
   Profile* profile = Profile::FromWebUI(web_ui());
   return profile->GetPrefs()->FindPreference(name)->GetValue();
 }