Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: sync/internal_api/public/base/invalidation_test_util.cc

Issue 23441042: Refactor common invalidation framework types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move DEPS rule Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/base/invalidation_test_util.cc
diff --git a/sync/internal_api/public/base/invalidation_test_util.cc b/sync/internal_api/public/base/invalidation_test_util.cc
index 3f3910be72f1f857c614a703da4e3ca10fb92a7e..3c610dadedc1e5ff3222a82d4f0f25b02b19c9a6 100644
--- a/sync/internal_api/public/base/invalidation_test_util.cc
+++ b/sync/internal_api/public/base/invalidation_test_util.cc
@@ -75,7 +75,18 @@ InvalidationEqMatcher::InvalidationEqMatcher(
bool InvalidationEqMatcher::MatchAndExplain(
const Invalidation& actual, MatchResultListener* listener) const {
- return expected_.payload == actual.payload;
+ if (!(expected_.object_id() == actual.object_id())) {
+ return false;
+ }
+ if (expected_.is_unknown_version() && actual.is_unknown_version()) {
+ return true;
+ } else if (expected_.is_unknown_version() != actual.is_unknown_version()) {
+ return false;
+ } else {
+ // Neither is unknown version.
+ return expected_.payload() == actual.payload()
+ && expected_.version() == actual.version();
+ }
}
void InvalidationEqMatcher::DescribeTo(::std::ostream* os) const {
@@ -99,12 +110,8 @@ Matcher<const AckHandle&> Eq(const AckHandle& expected) {
return MakeMatcher(new AckHandleEqMatcher(expected));
}
-void PrintTo(const Invalidation& state, ::std::ostream* os) {
- std::string printable_payload;
- base::JsonDoubleQuote(state.payload,
- true /* put_in_quotes */,
- &printable_payload);
- *os << "{ payload: " << printable_payload << " }";
+void PrintTo(const Invalidation& inv, ::std::ostream* os) {
+ *os << "{ payload: " << inv.ToString() << " }";
}
Matcher<const Invalidation&> Eq(const Invalidation& expected) {
« no previous file with comments | « sync/internal_api/public/base/invalidation_test_util.h ('k') | sync/internal_api/public/base/model_type_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698