[SystemInfo API] Rewrite DisplayInfoProvider without SystemInfoProvider.

chrome/browser/extensions/api/system_display/system_display_api.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_SYSTEM_DISPLAY_SYSTEM_DISPLAY_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_SYSTEM_DISPLAY_SYSTEM_DISPLAY_API_H_
 
 #include <string>
 
-#include "chrome/browser/extensions/api/system_display/display_info_provider.h"
 #include "chrome/browser/extensions/extension_function.h"
 
 namespace extensions {
 
 class SystemDisplayGetInfoFunction : public AsyncExtensionFunction {

[oshima, 2013/09/03 23:14:46]

Shouldn't this be UIThreadExtensionFunction?

[Haojian Wu, 2013/09/04 12:11:33]

Refer to
http://www.chromium.org/developers/design-documents/extensions/proposed-chang...

An ExtensionFunction is implemented as subclasses of SyncExtensionFunction or
AsyncExtensionFunction.

UIThreadExtensionFunction is a upper level base class of
SyncExtensionFunction/AsyncExtensionFunction. If you look into
c/b/e/extension_function.h file, you will find ASyncExtensionFunction is just a
subclass of UIThreadExtensionFunction without doing external work.

And I don't find any ExtensionApiFunction inherit UIThreadExtensionFunction
directly.

So here I think it should be ASyncExtensionFunction.

[oshima, 2013/09/06 18:30:48]

Shouldn't this be SyncExtensionFunction then?

[Haojian Wu, 2013/09/07 03:16:53]

Oh, Yeah. Should be SyncExtensionFunction. Done.

  public:
   DECLARE_EXTENSION_FUNCTION("system.display.getInfo",
                              SYSTEM_DISPLAY_GETINFO);
 
  protected:
   virtual ~SystemDisplayGetInfoFunction() {}
   virtual bool RunImpl() OVERRIDE;
-
- private:
-  void OnGetDisplayInfoCompleted(bool success);
 };
 
 class SystemDisplaySetDisplayPropertiesFunction
     : public AsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("system.display.setDisplayProperties",
                              SYSTEM_DISPLAY_SETDISPLAYPROPERTIES);
 
  protected:
   virtual ~SystemDisplaySetDisplayPropertiesFunction() {}
   virtual bool RunImpl() OVERRIDE;
-
- private:
-  void OnPropertiesSet(bool success, const std::string& error);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_SYSTEM_DISPLAY_SYSTEM_DISPLAY_API_H_