Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 23441027: Set line break mode for omnibox field editor (Closed)

Created:
7 years, 3 months ago by sail
Modified:
7 years, 3 months ago
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Set line break mode for omnibox field editor BUG=276612 TEST=Navigate to http://tinyurl.com/lqqdspt. Verify that clicking on the omnibox doesn't cause the tex to change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sail
7 years, 3 months ago (2013-09-01 03:53:50 UTC) #1
Scott Hess - ex-Googler
lgtm. Just to be certain, did you check horizontal scrolling? With the previous thing it ...
7 years, 3 months ago (2013-09-02 14:05:57 UTC) #2
sail
On 2013/09/02 14:05:57, shess wrote: > lgtm. > > Just to be certain, did you ...
7 years, 3 months ago (2013-09-03 16:25:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/23441027/1
7 years, 3 months ago (2013-09-03 16:25:37 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 19:21:10 UTC) #5
Message was sent while issue was closed.
Change committed as 220998

Powered by Google App Engine
This is Rietveld 408576698