Implement put_accvalue for textfields and location bar.

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/command_line.h"
@@ skipping 1282 matching lines @@
     // mid-point between two page actions in the bounding rectangle.  For even
     // paddings, the +1 is dropped, which is right since there is no pixel at
     // the mid-point.
     bounds.Inset(-(horizontal_padding + 1) / 2, 0);
     location_bar_util::PaintExtensionActionBackground(
         *(*page_action_view)->image_view()->page_action(),
         tab_id, canvas, bounds, text_color, background_color);
   }
 }
 
+void LocationBarView::AccessibilitySetValue(const string16& new_value) {
+  location_entry_->SetUserText(new_value);
+  location_entry_->SelectAll(false);

[msw, 2013/08/31 20:22:36]

This does not clear the selection as the AccessibilitySetValue function comment
claims. This selects all the text; false simply means that the select-all
selection will not be reversed. I believe the OmniboxView::SetUserText call
above is sufficient and will do the right thing on its own, since it's
implementation calls SetWindowTextAndCaretPos with |caret_pos| at the length of
the input, |display_text.length()|.

[dmazzoni, 2013/09/03 20:20:11]

Done.

+}
+
 const char* LocationBarView::GetClassName() const {
   return kViewClassName;
 }
 
 bool LocationBarView::SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) {
 #if defined(OS_WIN)
   if (views::FocusManager::IsTabTraversalKeyEvent(event)) {
     if (location_entry_->model()->popup_model()->IsOpen()) {
       // Return true so that the edit sees the tab and moves the selection.
       return true;
@@ skipping 21 matching lines @@
 void LocationBarView::GetAccessibleState(ui::AccessibleViewState* state) {
   state->role = ui::AccessibilityTypes::ROLE_LOCATION_BAR;
   state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_LOCATION);
   state->value = location_entry_->GetText();
 
   string16::size_type entry_start;
   string16::size_type entry_end;
   location_entry_->GetSelectionBounds(&entry_start, &entry_end);
   state->selection_start = entry_start;
   state->selection_end = entry_end;
+
+  state->set_value_callback = base::Bind(
+      &LocationBarView::AccessibilitySetValue, base::Unretained(this));

[msw, 2013/08/31 20:22:36]

base::Unretained is probably not correct here, I think you might be able to
construct a WeakPtrFactory for |location_entry_| and pass a binding to its
OmniboxView::SetUserText, since that's stored as a scoped_ptr by this class. I'm
sure other similar options are possible if that's not ideal.

[dmazzoni, 2013/09/03 20:20:11]

I don't think we need to bind to location_entry_, right? It
doesn't look like it will ever get cleared. I switched to a
WeakPtr bound to this object, that should work fine.

[msw, 2013/09/03 21:06:57]

Binding to a LocationBarView WeakPtr is just as good.

 }
 
 bool LocationBarView::HasFocus() const {
   return location_entry_->model()->has_focus();
 }
 
 void LocationBarView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   if (browser_ && browser_->instant_controller() && parent())
     browser_->instant_controller()->SetOmniboxBounds(bounds());
   OmniboxPopupView* popup = location_entry_->model()->popup_model()->view();
@@ skipping 199 matching lines @@
 int LocationBarView::GetInternalHeight(bool use_preferred_size) {
   int total_height =
       use_preferred_size ? GetPreferredSize().height() : height();
   return std::max(total_height - (vertical_edge_thickness() * 2), 0);
 }
 
 bool LocationBarView::HasValidSuggestText() const {
   return suggested_text_view_->visible() &&
       !suggested_text_view_->size().IsEmpty();
 }