Make it possibe to lock the fixedLayoutSize

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 361 matching lines @@
     , m_autofillClient(0)
     , m_permissionClient(0)
     , m_spellCheckClient(0)
     , m_passwordGeneratorClient(0)
     , m_chromeClientImpl(this)
     , m_contextMenuClientImpl(this)
     , m_dragClientImpl(this)
     , m_editorClientImpl(this)
     , m_inspectorClientImpl(this)
     , m_backForwardClientImpl(this)
+    , m_forceFixedLayoutSizeToEqualSize(false)
     , m_shouldAutoResize(false)
     , m_observedNewNavigation(false)
 #ifndef NDEBUG
     , m_newNavigationLoader(0)
 #endif
     , m_zoomLevel(0)
     , m_minimumZoomLevel(zoomFactorToZoomLevel(minTextSizeMultiplier))
     , m_maximumZoomLevel(zoomFactorToZoomLevel(maxTextSizeMultiplier))
     , m_savedPageScaleFactor(0)
     , m_doubleTapZoomPageScaleFactor(0)
@@ skipping 2610 matching lines @@
     m_pageScaleConstraintsSet.updatePageDefinedConstraints(arguments, m_size, page()->settings().layoutFallbackWidth());
 
     if (settingsImpl()->supportDeprecatedTargetDensityDPI())
         m_pageScaleConstraintsSet.adjustPageDefinedConstraintsForAndroidWebView(arguments, m_size, page()->settings().layoutFallbackWidth(), deviceScaleFactor(), page()->settings().useWideViewport(), page()->settings().loadWithOverviewMode());
 
     WebSize layoutSize = flooredIntSize(m_pageScaleConstraintsSet.pageDefinedConstraints().layoutSize);
 
     if (page()->settings().textAutosizingEnabled() && page()->mainFrame() && layoutSize.width != fixedLayoutSize().width)
         page()->mainFrame()->document()->textAutosizer()->recalculateMultipliers();
 
-    setFixedLayoutSize(layoutSize);
+    if (!m_shouldAutoResize)
+        setFixedLayoutSize(layoutSize);
 }
 
 IntSize WebViewImpl::contentsSize() const
 {
     RenderView* root = page()->mainFrame()->contentRenderer();
     if (!root)
         return IntSize();
     return root->documentRect().size();
 }
 
@@ skipping 71 matching lines @@
 
 void WebViewImpl::setFixedLayoutSize(const WebSize& layoutSize)
 {
     if (!page())
         return;
 
     Frame* frame = page()->mainFrame();
     if (!frame || !frame->view())
         return;
 
-    frame->view()->setFixedLayoutSize(layoutSize);
+    if (m_forceFixedLayoutSizeToEqualSize)
+        frame->view()->setFixedLayoutSize(m_size);
+    else
+        frame->view()->setFixedLayoutSize(layoutSize);
+
+}
+
+void WebViewImpl::setForceFixedLayoutSizeToEqualSize(bool value)
+{
+    m_forceFixedLayoutSizeToEqualSize = value;
 }
 
 void WebViewImpl::performMediaPlayerAction(const WebMediaPlayerAction& action,
                                            const WebPoint& location)
 {
     HitTestResult result = hitTestResultForWindowPos(location);
     RefPtr<Node> node = result.innerNonSharedNode();
     if (!isHTMLVideoElement(node.get()) && !node->hasTagName(HTMLNames::audioTag))
         return;
 
@@ skipping 529 matching lines @@
         // that means it's time to start producing frames again so un-defer.
         if (m_layerTreeView)
             m_layerTreeView->setDeferCommits(false);
         m_layerTreeViewCommitsDeferred = false;
     }
 
     if (m_shouldAutoResize && mainFrameImpl()->frame() && mainFrameImpl()->frame()->view()) {
         WebSize frameSize = mainFrameImpl()->frame()->view()->frameRect().size();
         if (frameSize != m_size) {
             m_size = frameSize;
-            m_client->didAutoResize(m_size);
+            if (!m_forceFixedLayoutSizeToEqualSize)

[mkosiba (inactive), 2013/08/30 18:25:09]

the reason for this is that it causes RenderWidget to resize the compositor to
m_size * dipScale.

[aelias_OOO_until_Jul13, 2013/08/31 03:45:04]

Could you explain why that's wrong?  Is it because of page scale or something
else?

[mkosiba (inactive), 2013/09/02 11:28:58]

Page scale mostly. My concern is that this ends up overriding the
physical_backing_size
AwContents has previously set. Even if the RenderWidget factored in the
pageScale correctly
there could still rounding errors.
The AutoResize code was written with the assumption that the size of the popup
window can be
freely altered. This is not the case for webview.

+                m_client->didAutoResize(m_size);
             sendResizeEventAndRepaint();
         }
     }
 
     if (m_pageScaleConstraintsSet.constraintsDirty())
         refreshPageScaleFactorAfterLayout();
 
     m_client->didUpdateLayout();
 }
 
@@ skipping 452 matching lines @@
 }
 
 bool WebViewImpl::shouldDisableDesktopWorkarounds()
 {
     ViewportArguments arguments = mainFrameImpl()->frame()->document()->viewportArguments();
     return arguments.width == ViewportArguments::ValueDeviceWidth || !arguments.userZoom
         || (arguments.minZoom == arguments.maxZoom && arguments.minZoom != ViewportArguments::ValueAuto);
 }
 
 } // namespace WebKit