Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/hydrogen.cc

Issue 23441018: Make VisitStatements() consistent among all AstVisitor implementations (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.cc ('k') | test/mjsunit/compiler/type-feedback-after-throw.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3095 matching lines...) Expand 10 before | Expand all | Expand 10 after
3106 } 3106 }
3107 3107
3108 environment()->Bind(scope->arguments(), 3108 environment()->Bind(scope->arguments(),
3109 graph()->GetArgumentsObject()); 3109 graph()->GetArgumentsObject());
3110 } 3110 }
3111 } 3111 }
3112 3112
3113 3113
3114 void HOptimizedGraphBuilder::VisitStatements(ZoneList<Statement*>* statements) { 3114 void HOptimizedGraphBuilder::VisitStatements(ZoneList<Statement*>* statements) {
3115 for (int i = 0; i < statements->length(); i++) { 3115 for (int i = 0; i < statements->length(); i++) {
3116 CHECK_ALIVE(Visit(statements->at(i))); 3116 Statement* stmt = statements->at(i);
3117 CHECK_ALIVE(Visit(stmt));
3118 if (stmt->IsJump()) break;
3117 } 3119 }
3118 } 3120 }
3119 3121
3120 3122
3121 void HOptimizedGraphBuilder::VisitBlock(Block* stmt) { 3123 void HOptimizedGraphBuilder::VisitBlock(Block* stmt) {
3122 ASSERT(!HasStackOverflow()); 3124 ASSERT(!HasStackOverflow());
3123 ASSERT(current_block() != NULL); 3125 ASSERT(current_block() != NULL);
3124 ASSERT(current_block()->HasPredecessor()); 3126 ASSERT(current_block()->HasPredecessor());
3125 if (stmt->scope() != NULL) { 3127 if (stmt->scope() != NULL) {
3126 return Bailout(kScopedBlock); 3128 return Bailout(kScopedBlock);
(...skipping 6610 matching lines...) Expand 10 before | Expand all | Expand 10 after
9737 if (ShouldProduceTraceOutput()) { 9739 if (ShouldProduceTraceOutput()) {
9738 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9740 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9739 } 9741 }
9740 9742
9741 #ifdef DEBUG 9743 #ifdef DEBUG
9742 graph_->Verify(false); // No full verify. 9744 graph_->Verify(false); // No full verify.
9743 #endif 9745 #endif
9744 } 9746 }
9745 9747
9746 } } // namespace v8::internal 9748 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.cc ('k') | test/mjsunit/compiler/type-feedback-after-throw.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698