[MD settings] Adjust toggle button dot slightly

[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. It also adjusts the shadow and translation. These
adjustments are needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9b19640f013ef467905582bde87a8f0090be694b
Cr-Commit-Position: refs/heads/master@{#419330}

[dschuyler, 2016-09-16 00:57:58]

Description was changed from

==========
[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. This
adjustment is needed for the compact toggle button.

BUG=646003
==========

to

==========
[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. This
adjustment is needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-09-16 00:58:00]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 00:58:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 01:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 01:08:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dschuyler, 2016-09-16 01:14:12]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[Dan Beam, 2016-09-16 01:19:23]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-09-16 01:19:23]

what about the other things mentioned in the CL?

[Dan Beam, 2016-09-16 01:19:32]

in the bug*

[dschuyler, 2016-09-16 01:24:43]

On 2016/09/16 01:19:32, Dan Beam wrote:
> in the bug*

The 20px from the edge question?
It's 20px from the edge to the button the the button to the right.
It's slightly over 20px from edge to bar when the button is on the left.

I think the bug was filled when there was more room
between the edge to the button, even when the button
was on the right. If I'm correct, that was adjusted
in CL 2317403004.

[Dan Beam, 2016-09-16 01:32:24]

On 2016/09/16 01:24:43, dschuyler wrote:
> On 2016/09/16 01:19:32, Dan Beam wrote:
> > in the bug*
> 
> The 20px from the edge question?
> It's 20px from the edge to the button the the button to the right.
> It's slightly over 20px from edge to bar when the button is on the left.
> 
> I think the bug was filled when there was more room
> between the edge to the button, even when the button
> was on the right. If I'm correct, that was adjusted
> in CL 2317403004.

bettes asked for 3 changes:

box-shadow
tranform
top

in this CL, I only see

top

what about the other 2/

[Dan Beam, 2016-09-16 01:34:36]

lgtm

[tommycli, 2016-09-16 17:47:27]

lgtm

[dschuyler, 2016-09-16 19:13:00]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 19:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-09-16 19:14:10]

Description was changed from

==========
[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. This
adjustment is needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. It also adjusts
the shadow and translation. These
adjustments are needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-09-16 19:15:22]

I've added the other adjustments to the toggle button.
PTAL and SLGTM if appropriate.

[commit-bot: I haz the power, 2016-09-16 20:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 20:18:24]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-09-16 23:32:11]

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:37: width: 31px;
What was this change for?

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:49: box-shadow: 0 1px
3px 0 rgba(0, 0, 0, 0.4);
custom shadow per alan in the bug I take it?

[tommycli, 2016-09-16 23:32:11]

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:37: width: 31px;
What was this change for?

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:49: box-shadow: 0 1px
3px 0 rgba(0, 0, 0, 0.4);
custom shadow per alan in the bug I take it?

[dschuyler, 2016-09-16 23:35:44]

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:37: width: 31px;
On 2016/09/16 23:32:11, tommycli wrote:
> What was this change for?

It's to make the bounding box slim enough
that the toggle lands on the edges of the
element. So that the control looks like 
it's correctly placed. Without the change
there is extra space between the control
and edge of the card.

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2344083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:49: box-shadow: 0 1px
3px 0 rgba(0, 0, 0, 0.4);
On 2016/09/16 23:32:11, tommycli wrote:
> custom shadow per alan in the bug I take it?

Verbatim.

[tommycli, 2016-09-16 23:37:49]

still lgtm then

[dschuyler, 2016-09-16 23:40:54]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-09-16 23:40:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2344083002/#ps20001
(title: "adding other touchups")

[commit-bot: I haz the power, 2016-09-16 23:41:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:45:55]

Description was changed from

==========
[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. It also adjusts
the shadow and translation. These
adjustments are needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. It also adjusts
the shadow and translation. These
adjustments are needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-16 23:45:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 23:47:36]

Description was changed from

==========
[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. It also adjusts
the shadow and translation. These
adjustments are needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] Move toggle button dot slightly

This CL moves the circle/dot part of the toggle button slightly. It also adjusts
the shadow and translation. These
adjustments are needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9b19640f013ef467905582bde87a8f0090be694b
Cr-Commit-Position: refs/heads/master@{#419330}
==========

[commit-bot: I haz the power, 2016-09-16 23:47:37]

Patchset 2 (id:??) landed as
https://crrev.com/9b19640f013ef467905582bde87a8f0090be694b
Cr-Commit-Position: refs/heads/master@{#419330}