Source/bindings/v8/ScriptValue.cpp - Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptValue.cpp

Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: BOOL*_BOOL -> BOOL* Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptValue.cpp

diff --git a/Source/bindings/v8/ScriptValue.cpp b/Source/bindings/v8/ScriptValue.cpp

index 793f7ec9a9116999496af7f2f6196f20436466a5..8014516e340adecd288d822fd310b0f5a07bd5c8 100644

--- a/Source/bindings/v8/ScriptValue.cpp

+++ b/Source/bindings/v8/ScriptValue.cpp

@@ -109,7 +109,7 @@ static PassRefPtr<JSONValue> v8ToJSONValue(v8::Handle<v8::Value> value, int maxD

RefPtr<JSONValue> propertyValue = v8ToJSONValue(object->Get(name), maxDepth, isolate);

if (!propertyValue)

return nullptr;

- V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<WithNullCheck>, nameString, name, nullptr);

+ TOSTRING_BOOL(V8StringResource<WithNullCheck>, nameString, name, nullptr);

jsonObject->setValue(nameString, propertyValue);

}

return jsonObject;