Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp - Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp

Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp

diff --git a/Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp b/Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp

index 7abd28e96536cf41211936c237ce395281c0e598..c333d9e077dcd91710c264e3664f4cc063836af7 100644

--- a/Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp

+++ b/Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp

@@ -48,9 +48,9 @@ void V8XSLTProcessor::setParameterMethodCustom(const v8::FunctionCallbackInfo<v8

if (isUndefinedOrNull(info[1]) || isUndefinedOrNull(info[2]))

return;

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, namespaceURI, info[0]);

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, localName, info[1]);

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, value, info[2]);

+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<>, namespaceURI, info[0]);

+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<>, localName, info[1]);

+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<>, value, info[2]);

XSLTProcessor* impl = V8XSLTProcessor::toNative(info.Holder());

impl->setParameter(namespaceURI, localName, value);

@@ -61,8 +61,8 @@ void V8XSLTProcessor::getParameterMethodCustom(const v8::FunctionCallbackInfo<v8

if (isUndefinedOrNull(info[1]))

return;

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, namespaceURI, info[0]);

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, localName, info[1]);

+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<>, namespaceURI, info[0]);

+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<>, localName, info[1]);

XSLTProcessor* impl = V8XSLTProcessor::toNative(info.Holder());

String result = impl->getParameter(namespaceURI, localName);

@@ -77,8 +77,8 @@ void V8XSLTProcessor::removeParameterMethodCustom(const v8::FunctionCallbackInfo

if (isUndefinedOrNull(info[1]))

return;

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, namespaceURI, info[0]);

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, localName, info[1]);

+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<>, namespaceURI, info[0]);

+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<>, localName, info[1]);

XSLTProcessor* impl = V8XSLTProcessor::toNative(info.Holder());

impl->removeParameter(namespaceURI, localName);