Chromium Code Reviews

Unified Diff: Source/bindings/v8/custom/V8HistoryCustom.cpp

Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/bindings/v8/custom/V8HistoryCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HistoryCustom.cpp b/Source/bindings/v8/custom/V8HistoryCustom.cpp
index c29cdbcde4fcecba24e8dcbe9cfd5dda79a10a39..5ffabc1488f190e6e7b0fddb7415b80ce27b3d9b 100644
--- a/Source/bindings/v8/custom/V8HistoryCustom.cpp
+++ b/Source/bindings/v8/custom/V8HistoryCustom.cpp
@@ -66,8 +66,8 @@ void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
if (exceptionState.throwIfNeeded())
return;
- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);
- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, argumentOrNull(info, 2));
+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);
+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, argumentOrNull(info, 2));
History* history = V8History::toNative(info.Holder());
history->stateObjectAdded(historyState.release(), title, url, UpdateBackForwardList, exceptionState);
@@ -82,8 +82,8 @@ void V8History::replaceStateMethodCustom(const v8::FunctionCallbackInfo<v8::Valu
if (exceptionState.throwIfNeeded())
return;
- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);
- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, argumentOrNull(info, 2));
+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);
+ V8STRINGRESOURCE_PREPARE_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, argumentOrNull(info, 2));
History* history = V8History::toNative(info.Holder());
history->stateObjectAdded(historyState.release(), title, url, DoNotUpdateBackForwardList, exceptionState);

Powered by Google App Engine