Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/interface.cpp » ('j') | Source/bindings/v8/V8BindingMacros.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index 862b2a04d8388a46a10c8a114f20c6b16f3ea2f8..0dda631df575ff82a491b77def60e94501aff2df 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -420,14 +420,14 @@ def v8_value_to_local_cpp_value(idl_type, extended_attributes, v8_value, variabl
cpp_value = v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, index)
args = [this_cpp_type, variable_name, cpp_value]
if idl_type.base_type == 'DOMString' and not idl_type.array_or_sequence_type:
- v8trycatch_void = 'V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID'
+ macro = 'V8STRINGRESOURCE_PREPARE_VOID'
elif idl_type.is_integer_type:
- v8trycatch_void = 'V8TRYCATCH_EXCEPTION_VOID'
+ macro = 'V8TRYCATCH_VOID_EXCEPTION'
args.append('exceptionState')
else:
- v8trycatch_void = 'V8TRYCATCH_VOID'
+ macro = 'V8TRYCATCH_VOID'
- return '%s(%s)' % (v8trycatch_void, ', '.join(args))
+ return '%s(%s)' % (macro, ', '.join(args))
IdlType.v8_value_to_local_cpp_value = v8_value_to_local_cpp_value
IdlUnionType.v8_value_to_local_cpp_value = v8_value_to_local_cpp_value
« no previous file with comments | « no previous file | Source/bindings/templates/interface.cpp » ('j') | Source/bindings/v8/V8BindingMacros.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698