Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: Source/bindings/v8/custom/V8ElementCustom.cpp

Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: BOOL*_BOOL -> BOOL* Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 #include "core/dom/Element.h" 39 #include "core/dom/Element.h"
40 40
41 namespace WebCore { 41 namespace WebCore {
42 42
43 void V8Element::scrollLeftAttributeSetterCustom(v8::Local<v8::Value> value, cons t v8::PropertyCallbackInfo<void>& info) 43 void V8Element::scrollLeftAttributeSetterCustom(v8::Local<v8::Value> value, cons t v8::PropertyCallbackInfo<void>& info)
44 { 44 {
45 ExceptionState exceptionState(ExceptionState::SetterContext, "scrollLeft", " Element", info.Holder(), info.GetIsolate()); 45 ExceptionState exceptionState(ExceptionState::SetterContext, "scrollLeft", " Element", info.Holder(), info.GetIsolate());
46 Element* impl = V8Element::toNative(info.Holder()); 46 Element* impl = V8Element::toNative(info.Holder());
47 47
48 if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && value->IsObject()) { 48 if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && value->IsObject()) {
49 V8TRYCATCH_VOID(Dictionary, scrollOptionsHorizontal, Dictionary(value, i nfo.GetIsolate())); 49 TONATIVE_VOID(Dictionary, scrollOptionsHorizontal, Dictionary(value, inf o.GetIsolate()));
50 impl->setScrollLeft(scrollOptionsHorizontal, exceptionState); 50 impl->setScrollLeft(scrollOptionsHorizontal, exceptionState);
51 exceptionState.throwIfNeeded(); 51 exceptionState.throwIfNeeded();
52 return; 52 return;
53 } 53 }
54 54
55 V8TRYCATCH_EXCEPTION_VOID(int, position, toInt32(value, exceptionState), exc eptionState); 55 TONATIVE_VOID_EXCEPTIONSTATE(int, position, toInt32(value, exceptionState), exceptionState);
56 impl->setScrollLeft(position); 56 impl->setScrollLeft(position);
57 } 57 }
58 58
59 void V8Element::scrollTopAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info) 59 void V8Element::scrollTopAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
60 { 60 {
61 ExceptionState exceptionState(ExceptionState::SetterContext, "scrollTop", "E lement", info.Holder(), info.GetIsolate()); 61 ExceptionState exceptionState(ExceptionState::SetterContext, "scrollTop", "E lement", info.Holder(), info.GetIsolate());
62 Element* impl = V8Element::toNative(info.Holder()); 62 Element* impl = V8Element::toNative(info.Holder());
63 63
64 if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && value->IsObject()) { 64 if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && value->IsObject()) {
65 V8TRYCATCH_VOID(Dictionary, scrollOptionsVertical, Dictionary(value, inf o.GetIsolate())); 65 TONATIVE_VOID(Dictionary, scrollOptionsVertical, Dictionary(value, info. GetIsolate()));
66 impl->setScrollTop(scrollOptionsVertical, exceptionState); 66 impl->setScrollTop(scrollOptionsVertical, exceptionState);
67 exceptionState.throwIfNeeded(); 67 exceptionState.throwIfNeeded();
68 return; 68 return;
69 } 69 }
70 70
71 V8TRYCATCH_EXCEPTION_VOID(int, position, toInt32(value, exceptionState), exc eptionState); 71 TONATIVE_VOID_EXCEPTIONSTATE(int, position, toInt32(value, exceptionState), exceptionState);
72 impl->setScrollTop(position); 72 impl->setScrollTop(position);
73 } 73 }
74 74
75 } // namespace WebCore 75 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8DocumentCustom.cpp ('k') | Source/bindings/v8/custom/V8FileCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698