Delete ReplayReceivedData, make WebViewPlugin not a WebFrameClient

Delete ReplayReceivedData, make WebViewPlugin not a WebFrameClient

* WebViewPlugin only needs to be a WebFrameClient in order
to create a WebFrame, and to listen to didClearWindowObject.
Create a new private helper class to do this.

* WebViewPlugin::didReceiveResponse() no longer overrides
both WebFrameClient and WebPlugin, and will never receive
WebPlugin calllbacks. Make WebPlugin's resource load
callbacks NOTREACHED().

* ReplayReceivedData() only has one live clause, which is
to transfer focus state from the placeholder plugin to the
live plugin. RestoreTitleText() is similar. Expose
accessors for focus and title state, and use them in
LoadablePlaceholderPlugin, which is the only consumer of
that state.

BUG=

Committed: https://crrev.com/8e1badd5fbc054cf4ffc9303e8cb0aa22ce55ca6
Cr-Commit-Position: refs/heads/master@{#419837}

[Nate Chapin, 2016-09-15 22:07:27]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 22:07:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 23:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:02:24]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-09-16 21:07:45]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 21:08:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:09:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2016-09-19 19:16:20]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:17:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:10:03]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-09-19 21:43:43]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 21:44:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2016-09-19 23:46:12]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 23:46:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2016-09-19 23:48:09]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 23:48:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:06:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:06:27]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-09-20 17:37:34]

Description was changed from

==========
Delete ReplayReceivedData

BUG=
==========

to

==========
Delete ReplayReceivedData, make WebViewPlugin not a WebFrameClient

* WebViewPlugin only needs to be a WebFrameClient in order
to create a WebFrame, and to listen to didClearWindowObject.
Create a new private helper class to do this.

* WebViewPlugin::didReceiveResponse() no longer overrides
both WebFrameClient and WebPlugin, and will never receive
WebPlugin calllbacks. Make WebPlugin's resource load
callbacks NOTREACHED().

* ReplayReceivedData() only has one live clause, which is
to transfer focus state from the placeholder plugin to the
live plugin. RestoreTitleText() is similar. Expose
accessors for focus and title state, and use them in
LoadablePlaceholderPlugin, which is the only consumer of
that state.

BUG=
==========

[Nate Chapin, 2016-09-20 17:39:40]

japhet@chromium.org changed reviewers:
+ tommycli@chromium.org

[Nate Chapin, 2016-09-20 17:39:40]

Post crbug.com/641028 cleanup, PTAL :)

[tommycli, 2016-09-20 17:51:59]

whoa cool. lgtm

As I understand it, the didFinishLoading and didFailLoading(error) were dead
code that you've now marked with NOTREACHED() right?

[Nate Chapin, 2016-09-20 17:58:56]

On 2016/09/20 17:51:59, tommycli wrote:
> whoa cool. lgtm
> 
> As I understand it, the didFinishLoading and didFailLoading(error) were dead
> code that you've now marked with NOTREACHED() right?

Correct.

FWIW, I took a brief look just now at also moving the WebViewClient and
RenderViewObserver inheritance to PluginWebFrameClient, but that gets
substantially messier.

[Nate Chapin, 2016-09-20 17:59:01]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-09-20 17:59:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2344023002/#ps120001
(title: "PluginWebFrameClient::plugin_ should be private")

[commit-bot: I haz the power, 2016-09-20 17:59:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-09-20 18:34:04]

On 2016/09/20 17:58:56, Nate Chapin wrote:
> On 2016/09/20 17:51:59, tommycli wrote:
> > whoa cool. lgtm
> > 
> > As I understand it, the didFinishLoading and didFailLoading(error) were dead
> > code that you've now marked with NOTREACHED() right?
> 
> Correct.
> 
> FWIW, I took a brief look just now at also moving the WebViewClient and
> RenderViewObserver inheritance to PluginWebFrameClient, but that gets
> substantially messier.

Cool, thanks for the cleanup.

[commit-bot: I haz the power, 2016-09-20 19:16:45]

Description was changed from

==========
Delete ReplayReceivedData, make WebViewPlugin not a WebFrameClient

* WebViewPlugin only needs to be a WebFrameClient in order
to create a WebFrame, and to listen to didClearWindowObject.
Create a new private helper class to do this.

* WebViewPlugin::didReceiveResponse() no longer overrides
both WebFrameClient and WebPlugin, and will never receive
WebPlugin calllbacks. Make WebPlugin's resource load
callbacks NOTREACHED().

* ReplayReceivedData() only has one live clause, which is
to transfer focus state from the placeholder plugin to the
live plugin. RestoreTitleText() is similar. Expose
accessors for focus and title state, and use them in
LoadablePlaceholderPlugin, which is the only consumer of
that state.

BUG=
==========

to

==========
Delete ReplayReceivedData, make WebViewPlugin not a WebFrameClient

* WebViewPlugin only needs to be a WebFrameClient in order
to create a WebFrame, and to listen to didClearWindowObject.
Create a new private helper class to do this.

* WebViewPlugin::didReceiveResponse() no longer overrides
both WebFrameClient and WebPlugin, and will never receive
WebPlugin calllbacks. Make WebPlugin's resource load
callbacks NOTREACHED().

* ReplayReceivedData() only has one live clause, which is
to transfer focus state from the placeholder plugin to the
live plugin. RestoreTitleText() is similar. Expose
accessors for focus and title state, and use them in
LoadablePlaceholderPlugin, which is the only consumer of
that state.

BUG=
==========

[commit-bot: I haz the power, 2016-09-20 19:16:46]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-20 19:18:49]

Description was changed from

==========
Delete ReplayReceivedData, make WebViewPlugin not a WebFrameClient

* WebViewPlugin only needs to be a WebFrameClient in order
to create a WebFrame, and to listen to didClearWindowObject.
Create a new private helper class to do this.

* WebViewPlugin::didReceiveResponse() no longer overrides
both WebFrameClient and WebPlugin, and will never receive
WebPlugin calllbacks. Make WebPlugin's resource load
callbacks NOTREACHED().

* ReplayReceivedData() only has one live clause, which is
to transfer focus state from the placeholder plugin to the
live plugin. RestoreTitleText() is similar. Expose
accessors for focus and title state, and use them in
LoadablePlaceholderPlugin, which is the only consumer of
that state.

BUG=
==========

to

==========
Delete ReplayReceivedData, make WebViewPlugin not a WebFrameClient

* WebViewPlugin only needs to be a WebFrameClient in order
to create a WebFrame, and to listen to didClearWindowObject.
Create a new private helper class to do this.

* WebViewPlugin::didReceiveResponse() no longer overrides
both WebFrameClient and WebPlugin, and will never receive
WebPlugin calllbacks. Make WebPlugin's resource load
callbacks NOTREACHED().

* ReplayReceivedData() only has one live clause, which is
to transfer focus state from the placeholder plugin to the
live plugin. RestoreTitleText() is similar. Expose
accessors for focus and title state, and use them in
LoadablePlaceholderPlugin, which is the only consumer of
that state.

BUG=

Committed: https://crrev.com/8e1badd5fbc054cf4ffc9303e8cb0aa22ce55ca6
Cr-Commit-Position: refs/heads/master@{#419837}
==========

[commit-bot: I haz the power, 2016-09-20 19:18:50]

Patchset 7 (id:??) landed as
https://crrev.com/8e1badd5fbc054cf4ffc9303e8cb0aa22ce55ca6
Cr-Commit-Position: refs/heads/master@{#419837}