Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23440066: Block NPAPI plugins by default Add Facebook video calling and Google Earth plugins to the tracked l… (Closed)

Created:
7 years, 3 months ago by Cris Neckar
Modified:
7 years, 2 months ago
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, jam, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Block NPAPI plugins by default Add Facebook video calling and Google Earth plugins to the tracked list. BUG=281651 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225316

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : json version ++ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -11 lines) Patch
M chrome/browser/plugins/plugin_metadata.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/plugin_metadata/plugins_mac.json View 1 2 2 chunks +33 lines, -1 line 0 comments Download
M chrome/browser/resources/plugin_metadata/plugins_win.json View 1 2 2 chunks +33 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Cris Neckar
Context is here http://blog.chromium.org/2013/09/saying-goodbye-to-our-old-friend-npapi.html
7 years, 3 months ago (2013-09-24 18:03:29 UTC) #1
Bernhard Bauer
https://chromiumcodereview.appspot.com/23440066/diff/11001/chrome/browser/plugins/plugin_metadata.cc File chrome/browser/plugins/plugin_metadata.cc (right): https://chromiumcodereview.appspot.com/23440066/diff/11001/chrome/browser/plugins/plugin_metadata.cc#newcode100 chrome/browser/plugins/plugin_metadata.cc:100: if (plugin.type == content::WebPluginInfo::PLUGIN_TYPE_NPAPI) { This check isn't necessary. ...
7 years, 3 months ago (2013-09-24 18:16:56 UTC) #2
Cris Neckar
https://chromiumcodereview.appspot.com/23440066/diff/11001/chrome/browser/plugins/plugin_metadata.cc File chrome/browser/plugins/plugin_metadata.cc (right): https://chromiumcodereview.appspot.com/23440066/diff/11001/chrome/browser/plugins/plugin_metadata.cc#newcode100 chrome/browser/plugins/plugin_metadata.cc:100: if (plugin.type == content::WebPluginInfo::PLUGIN_TYPE_NPAPI) { On 2013/09/24 18:16:56, Bernhard ...
7 years, 3 months ago (2013-09-24 18:51:59 UTC) #3
Bernhard Bauer
lgtm
7 years, 3 months ago (2013-09-24 19:20:49 UTC) #4
Cris Neckar
incremented json version numbers per cevans@ request
7 years, 3 months ago (2013-09-24 20:43:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cdn@chromium.org/23440066/35001
7 years, 3 months ago (2013-09-24 20:53:02 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171431
7 years, 3 months ago (2013-09-24 23:55:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cdn@chromium.org/23440066/35001
7 years, 2 months ago (2013-09-25 19:41:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cdn@chromium.org/23440066/35001
7 years, 2 months ago (2013-09-25 21:24:02 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 04:07:07 UTC) #10
Message was sent while issue was closed. 
Change committed as 225316

Powered by Google App Engine
This is Rietveld 408576698