Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 23440064: Revert "Turn the NumberToStringStub into a hydrogen stub." (Closed)

Created:
7 years, 3 months ago by Michael Achenbach
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Revert "Turn the NumberToStringStub into a hydrogen stub." This reverts commit 16874 for breaking the tests. TBR=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -229 lines) Patch
M src/arm/code-stubs-arm.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +16 lines, -10 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +6 lines, -140 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +16 lines, -10 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Achenbach
Committed patchset #1 manually as r16876.
7 years, 3 months ago (2013-09-23 11:22:56 UTC) #1
Benedikt Meurer
7 years, 3 months ago (2013-09-23 11:23:36 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698