Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 23440054: Revert ignore-failures changes from r11395. (Closed)

Created:
7 years, 3 months ago by Stephen White
Modified:
7 years, 3 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert ignore-failures changes from r11395, since the tests have been rebaselined. TBR=epoger Committed: https://code.google.com/p/skia/source/detail?r=11407

Patch Set 1 #

Patch Set 2 : Don't put the failures in ignored-tests.txt; they're already rebaselined. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -497 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 8 chunks +8 lines, -12 lines 2 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 8 chunks +8 lines, -12 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 5 chunks +1 line, -5 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 5 chunks +1 line, -5 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 1 9 chunks +9 lines, -13 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 1 9 chunks +9 lines, -13 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 7 chunks +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 7 chunks +4 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 1 7 chunks +7 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 1 4 chunks +4 lines, -7 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 1 7 chunks +7 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 1 7 chunks +7 lines, -10 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 5 chunks +1 line, -5 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 1 5 chunks +1 line, -5 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 1 5 chunks +1 line, -5 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 1 5 chunks +1 line, -5 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 1 5 chunks +1 line, -5 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 1 5 chunks +1 line, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 13 chunks +11 lines, -17 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 11 chunks +11 lines, -15 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 13 chunks +11 lines, -17 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 12 chunks +11 lines, -16 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 14 chunks +12 lines, -19 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 13 chunks +12 lines, -18 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 14 chunks +12 lines, -19 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 13 chunks +12 lines, -18 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 11 chunks +1 line, -11 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 9 chunks +1 line, -9 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 11 chunks +1 line, -11 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 9 chunks +1 line, -9 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 1 9 chunks +7 lines, -12 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 1 9 chunks +7 lines, -12 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 1 9 chunks +8 lines, -12 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 1 9 chunks +7 lines, -12 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 1 9 chunks +7 lines, -12 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 1 9 chunks +1 line, -9 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 1 11 chunks +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 1 8 chunks +6 lines, -11 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 1 8 chunks +6 lines, -11 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 1 11 chunks +6 lines, -15 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 1 8 chunks +6 lines, -11 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 8 chunks +6 lines, -11 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 1 8 chunks +6 lines, -11 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 1 8 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
PTAL. I think my original suppressions worked, but I kind of hand-rolled the JSON, so ...
7 years, 3 months ago (2013-09-19 19:36:43 UTC) #1
Stephen White
Committed patchset #2 manually as r11407 (presubmit successful).
7 years, 3 months ago (2013-09-19 21:26:21 UTC) #2
epoger
https://codereview.chromium.org/23440054/diff/4001/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json File expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json (right): https://codereview.chromium.org/23440054/diff/4001/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json#newcode2 expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json:2: "actual-results": { I'm confused... https://code.google.com/p/skia/source/detail?r=11395 did not change any ...
7 years, 3 months ago (2013-09-23 15:14:09 UTC) #3
Stephen White
https://codereview.chromium.org/23440054/diff/4001/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json File expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json (right): https://codereview.chromium.org/23440054/diff/4001/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json#newcode2 expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json:2: "actual-results": { On 2013/09/23 15:14:09, epoger wrote: > I'm ...
7 years, 3 months ago (2013-09-23 17:11:58 UTC) #4
epoger
LGTM And the good news is, next time we can just use ignored-tests.txt instead. Right?
7 years, 3 months ago (2013-09-23 17:33:22 UTC) #5
Stephen White
7 years, 3 months ago (2013-09-23 17:39:44 UTC) #6
Message was sent while issue was closed.
On 2013/09/23 17:33:22, epoger wrote:
> LGTM
> 
> And the good news is, next time we can just use ignored-tests.txt instead. 
> Right?

Yes. Oh god yes.

Powered by Google App Engine
This is Rietveld 408576698