Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: remoting/client/plugin/pepper_view.h

Issue 23440046: Remove dependency on Skia from chromoting client. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This class is an implementation of the ChromotingView for Pepper. It is 5 // This class is an implementation of the ChromotingView for Pepper. It is
6 // callable only on the Pepper thread. 6 // callable only on the Pepper thread.
7 7
8 #ifndef REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_ 8 #ifndef REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
9 #define REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_ 9 #define REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
10 10
(...skipping 23 matching lines...) Expand all
34 class PepperView : public FrameConsumer { 34 class PepperView : public FrameConsumer {
35 public: 35 public:
36 // Constructs a PepperView for the |instance|. The |instance|, |context| 36 // Constructs a PepperView for the |instance|. The |instance|, |context|
37 // and |producer| must outlive this class. 37 // and |producer| must outlive this class.
38 PepperView(ChromotingInstance* instance, 38 PepperView(ChromotingInstance* instance,
39 ClientContext* context, 39 ClientContext* context,
40 FrameProducer* producer); 40 FrameProducer* producer);
41 virtual ~PepperView(); 41 virtual ~PepperView();
42 42
43 // FrameConsumer implementation. 43 // FrameConsumer implementation.
44 virtual void ApplyBuffer(const SkISize& view_size, 44 virtual void ApplyBuffer(const webrtc::DesktopSize& view_size,
45 const SkIRect& clip_area, 45 const webrtc::DesktopRect& clip_area,
46 webrtc::DesktopFrame* buffer, 46 webrtc::DesktopFrame* buffer,
47 const SkRegion& region) OVERRIDE; 47 const webrtc::DesktopRegion& region) OVERRIDE;
48 virtual void ReturnBuffer(webrtc::DesktopFrame* buffer) OVERRIDE; 48 virtual void ReturnBuffer(webrtc::DesktopFrame* buffer) OVERRIDE;
49 virtual void SetSourceSize(const SkISize& source_size, 49 virtual void SetSourceSize(const webrtc::DesktopSize& source_size,
50 const SkIPoint& dpi) OVERRIDE; 50 const webrtc::DesktopVector& dpi) OVERRIDE;
51 51
52 // Updates the PepperView's size & clipping area, taking into account the 52 // Updates the PepperView's size & clipping area, taking into account the
53 // DIP-to-device scale factor. 53 // DIP-to-device scale factor.
54 void SetView(const pp::View& view); 54 void SetView(const pp::View& view);
55 55
56 // Returns the dimensions of the most recently displayed frame, in pixels. 56 // Returns the dimensions of the most recently displayed frame, in pixels.
57 const SkISize& get_source_size() const { 57 const webrtc::DesktopSize& get_source_size() const {
58 return source_size_; 58 return source_size_;
59 } 59 }
60 60
61 // Return the dimensions of the view in Density Independent Pixels (DIPs). 61 // Return the dimensions of the view in Density Independent Pixels (DIPs).
62 // Note that there may be multiple device pixels per DIP. 62 // Note that there may be multiple device pixels per DIP.
63 const SkISize& get_view_size_dips() const { 63 const webrtc::DesktopSize& get_view_size_dips() const {
64 return dips_size_; 64 return dips_size_;
65 } 65 }
66 66
67 private: 67 private:
68 // Allocates a new frame buffer to supply to the FrameProducer to render into. 68 // Allocates a new frame buffer to supply to the FrameProducer to render into.
69 // Returns NULL if the maximum number of buffers has already been allocated. 69 // Returns NULL if the maximum number of buffers has already been allocated.
70 webrtc::DesktopFrame* AllocateBuffer(); 70 webrtc::DesktopFrame* AllocateBuffer();
71 71
72 // Frees a frame buffer previously allocated by AllocateBuffer. 72 // Frees a frame buffer previously allocated by AllocateBuffer.
73 void FreeBuffer(webrtc::DesktopFrame* buffer); 73 void FreeBuffer(webrtc::DesktopFrame* buffer);
74 74
75 // Allocates buffers and passes them to the FrameProducer to render into until 75 // Allocates buffers and passes them to the FrameProducer to render into until
76 // the maximum number of buffers are in-flight. 76 // the maximum number of buffers are in-flight.
77 void InitiateDrawing(); 77 void InitiateDrawing();
78 78
79 // Renders the parts of |buffer| identified by |region| to the view. If the 79 // Renders the parts of |buffer| identified by |region| to the view. If the
80 // clip area of the view has changed since the buffer was generated then 80 // clip area of the view has changed since the buffer was generated then
81 // FrameProducer is supplied the missed parts of |region|. The FrameProducer 81 // FrameProducer is supplied the missed parts of |region|. The FrameProducer
82 // will be supplied a new buffer when FlushBuffer() completes. 82 // will be supplied a new buffer when FlushBuffer() completes.
83 void FlushBuffer(const SkIRect& clip_area, 83 void FlushBuffer(const webrtc::DesktopRect& clip_area,
84 webrtc::DesktopFrame* buffer, 84 webrtc::DesktopFrame* buffer,
85 const SkRegion& region); 85 const webrtc::DesktopRegion& region);
86 86
87 // Handles completion of FlushBuffer(), triggering a new buffer to be 87 // Handles completion of FlushBuffer(), triggering a new buffer to be
88 // returned to FrameProducer for rendering. 88 // returned to FrameProducer for rendering.
89 void OnFlushDone(int result, 89 void OnFlushDone(int result,
90 const base::Time& paint_start, 90 const base::Time& paint_start,
91 webrtc::DesktopFrame* buffer); 91 webrtc::DesktopFrame* buffer);
92 92
93 // Reference to the creating plugin instance. Needed for interacting with 93 // Reference to the creating plugin instance. Needed for interacting with
94 // pepper. Marking explicitly as const since it must be initialized at 94 // pepper. Marking explicitly as const since it must be initialized at
95 // object creation, and never change. 95 // object creation, and never change.
96 ChromotingInstance* const instance_; 96 ChromotingInstance* const instance_;
97 97
98 // Context should be constant for the lifetime of the plugin. 98 // Context should be constant for the lifetime of the plugin.
99 ClientContext* const context_; 99 ClientContext* const context_;
100 100
101 pp::Graphics2D graphics2d_; 101 pp::Graphics2D graphics2d_;
102 102
103 FrameProducer* producer_; 103 FrameProducer* producer_;
104 104
105 // List of allocated image buffers. 105 // List of allocated image buffers.
106 std::list<webrtc::DesktopFrame*> buffers_; 106 std::list<webrtc::DesktopFrame*> buffers_;
107 107
108 // Queued buffer to paint, with clip area and dirty region in device pixels. 108 // Queued buffer to paint, with clip area and dirty region in device pixels.
109 webrtc::DesktopFrame* merge_buffer_; 109 webrtc::DesktopFrame* merge_buffer_;
110 SkIRect merge_clip_area_; 110 webrtc::DesktopRect merge_clip_area_;
111 SkRegion merge_region_; 111 webrtc::DesktopRegion merge_region_;
112 112
113 // View size in Density Independent Pixels (DIPs). 113 // View size in Density Independent Pixels (DIPs).
114 SkISize dips_size_; 114 webrtc::DesktopSize dips_size_;
115 115
116 // Scale factor from DIPs to device pixels. 116 // Scale factor from DIPs to device pixels.
117 float dips_to_device_scale_; 117 float dips_to_device_scale_;
118 118
119 // View size in output pixels. This is the size at which FrameProducer must 119 // View size in output pixels. This is the size at which FrameProducer must
120 // render frames. It usually matches the DIPs size of the view, but may match 120 // render frames. It usually matches the DIPs size of the view, but may match
121 // the size in device pixels when scaling is in effect, to reduce artefacts. 121 // the size in device pixels when scaling is in effect, to reduce artefacts.
122 SkISize view_size_; 122 webrtc::DesktopSize view_size_;
123 123
124 // Scale factor from output pixels to device pixels. 124 // Scale factor from output pixels to device pixels.
125 float dips_to_view_scale_; 125 float dips_to_view_scale_;
126 126
127 // Visible area of the view, in output pixels. 127 // Visible area of the view, in output pixels.
128 SkIRect clip_area_; 128 webrtc::DesktopRect clip_area_;
129 129
130 // Size of the most recent source frame in pixels. 130 // Size of the most recent source frame in pixels.
131 SkISize source_size_; 131 webrtc::DesktopSize source_size_;
132 132
133 // Resolution of the most recent source frame dots-per-inch. 133 // Resolution of the most recent source frame dots-per-inch.
134 SkIPoint source_dpi_; 134 webrtc::DesktopVector source_dpi_;
135 135
136 // True if there is already a Flush() pending on the Graphics2D context. 136 // True if there is already a Flush() pending on the Graphics2D context.
137 bool flush_pending_; 137 bool flush_pending_;
138 138
139 // True after Initialize() has been called, until TearDown(). 139 // True after Initialize() has been called, until TearDown().
140 bool is_initialized_; 140 bool is_initialized_;
141 141
142 // True after the first call to ApplyBuffer(). 142 // True after the first call to ApplyBuffer().
143 bool frame_received_; 143 bool frame_received_;
144 144
145 pp::CompletionCallbackFactory<PepperView> callback_factory_; 145 pp::CompletionCallbackFactory<PepperView> callback_factory_;
146 146
147 DISALLOW_COPY_AND_ASSIGN(PepperView); 147 DISALLOW_COPY_AND_ASSIGN(PepperView);
148 }; 148 };
149 149
150 } // namespace remoting 150 } // namespace remoting
151 151
152 #endif // REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_ 152 #endif // REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698