Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23440046: Remove dependency on Skia from chromoting client. (Closed)

Created:
7 years, 3 months ago by Sergey Ulanov
Modified:
7 years, 2 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove dependency on Skia from chromoting client. Now DesktopRegion, DesktopRect and DesktopSize are used instead of corresponding skia types. R=alexeypa@chromium.org TBR=reed@google.com (for _moved_ skia dependency) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225265

Patch Set 1 #

Patch Set 2 : #

Total comments: 16

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -471 lines) Patch
M remoting/DEPS View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/base/util.h View 4 chunks +24 lines, -20 lines 0 comments Download
M remoting/base/util.cc View 1 2 6 chunks +74 lines, -63 lines 0 comments Download
M remoting/base/util_unittest.cc View 1 2 8 chunks +29 lines, -32 lines 0 comments Download
M remoting/client/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/frame_consumer.h View 1 2 3 chunks +9 lines, -8 lines 0 comments Download
M remoting/client/frame_consumer_proxy.h View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/client/frame_consumer_proxy.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M remoting/client/frame_producer.h View 3 chunks +7 lines, -7 lines 0 comments Download
M remoting/client/jni/jni_frame_consumer.h View 1 2 3 4 5 6 7 8 3 chunks +8 lines, -7 lines 0 comments Download
M remoting/client/jni/jni_frame_consumer.cc View 1 2 3 4 5 6 7 8 4 chunks +9 lines, -8 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 4 chunks +10 lines, -6 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M remoting/client/plugin/pepper_view.h View 1 2 5 chunks +18 lines, -16 lines 0 comments Download
M remoting/client/plugin/pepper_view.cc View 11 chunks +27 lines, -33 lines 0 comments Download
M remoting/client/rectangle_update_decoder.h View 1 2 3 chunks +10 lines, -8 lines 0 comments Download
M remoting/client/rectangle_update_decoder.cc View 1 2 3 4 5 6 7 8 9 7 chunks +22 lines, -24 lines 0 comments Download
M remoting/codec/codec_test.cc View 1 2 3 4 5 6 7 8 9 6 chunks +14 lines, -17 lines 0 comments Download
M remoting/codec/video_decoder.h View 1 2 3 4 5 6 7 8 9 4 chunks +13 lines, -10 lines 0 comments Download
M remoting/codec/video_decoder_verbatim.h View 1 2 3 4 5 6 7 8 9 2 chunks +11 lines, -9 lines 0 comments Download
M remoting/codec/video_decoder_verbatim.cc View 1 2 3 4 5 6 7 8 9 4 chunks +35 lines, -32 lines 0 comments Download
M remoting/codec/video_decoder_vp8.h View 1 2 3 4 5 6 7 8 9 4 chunks +17 lines, -13 lines 0 comments Download
M remoting/codec/video_decoder_vp8.cc View 1 2 3 4 5 6 7 8 9 8 chunks +79 lines, -76 lines 0 comments Download
M remoting/codec/video_encoder_vp8.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/codec/video_encoder_vp8.cc View 6 chunks +26 lines, -20 lines 0 comments Download
remoting/host/DEPS View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -1 line 0 comments Download
M remoting/host/mouse_clamping_filter.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/protocol/input_event_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/input_event_tracker.cc View 2 chunks +1 line, -2 lines 0 comments Download
M remoting/protocol/mouse_input_filter.h View 2 chunks +5 lines, -6 lines 0 comments Download
M remoting/protocol/mouse_input_filter.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M remoting/protocol/mouse_input_filter_unittest.cc View 1 2 3 4 7 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Sergey Ulanov
7 years, 3 months ago (2013-09-18 22:32:19 UTC) #1
alexeypa (please no reviews)
lgtm https://codereview.chromium.org/23440046/diff/3001/remoting/base/util.cc File remoting/base/util.cc (right): https://codereview.chromium.org/23440046/diff/3001/remoting/base/util.cc#newcode117 remoting/base/util.cc:117: RoundToTwosMultiple(dest_rect.top() + 1), nit: indentation https://codereview.chromium.org/23440046/diff/3001/remoting/base/util.cc#newcode139 remoting/base/util.cc:139: RoundToTwosMultiple(dest_rect.top()), ...
7 years, 3 months ago (2013-09-18 23:04:05 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/23440046/diff/3001/remoting/base/util.cc File remoting/base/util.cc (right): https://codereview.chromium.org/23440046/diff/3001/remoting/base/util.cc#newcode117 remoting/base/util.cc:117: RoundToTwosMultiple(dest_rect.top() + 1), On 2013/09/18 23:04:05, alexeypa wrote: > ...
7 years, 3 months ago (2013-09-18 23:26:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23440046/10001
7 years, 3 months ago (2013-09-18 23:29:03 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=26207
7 years, 3 months ago (2013-09-18 23:41:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23440046/18001
7 years, 3 months ago (2013-09-19 00:21:24 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=26250
7 years, 3 months ago (2013-09-19 00:35:36 UTC) #7
Sergey Ulanov
+reed@google.com in TBR for moved skia dependency
7 years, 3 months ago (2013-09-19 00:37:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23440046/18001
7 years, 3 months ago (2013-09-19 00:38:28 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-19 00:50:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23440046/38001
7 years, 3 months ago (2013-09-19 00:56:42 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-19 01:33:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23440046/11001
7 years, 3 months ago (2013-09-19 01:43:45 UTC) #13
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-19 01:56:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23440046/28001
7 years, 3 months ago (2013-09-19 04:42:47 UTC) #15
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-19 04:48:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23440046/28001
7 years, 3 months ago (2013-09-19 04:49:43 UTC) #17
commit-bot: I haz the power
Change committed as 224101
7 years, 3 months ago (2013-09-19 10:31:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23440046/86001
7 years, 3 months ago (2013-09-25 00:01:47 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=80486
7 years, 3 months ago (2013-09-25 02:29:36 UTC) #20
Sergey Ulanov
7 years, 2 months ago (2013-09-25 22:18:25 UTC) #21
Message was sent while issue was closed. 
Committed patchset #10 manually as r225265 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698